Bug 648877 – Evolution-ews address completion gives mailbox name rather than contact name

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 648877 - Evolution-ews address completion gives mailbox name rather than contact name


Summary:	Evolution-ews address completion gives mailbox name rather than contact name


Status:	RESOLVED FIXED

Product:	evolution-ews
Classification:	Other
Component:	Contacts (Global Address List)
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal minor
Target Milestone:	---
Assigned To:	Chenthill P
QA Contact:	Evolution QA team

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2011-04-28 15:16 UTC by Kåre Fiedler Chrisitiansen
Modified:	2011-12-08 08:34 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
proposed ews patch (7.06 KB, patch) 2011-11-21 14:02 UTC, Milan Crha	none	Details \| Review
proposed ews patch ][ (7.23 KB, patch) 2011-11-23 10:04 UTC, Milan Crha	committed	Details \| Review

Description Kåre Fiedler Chrisitiansen 2011-04-28 15:16:13 UTC

When using evolution-ews to connect to an exchange server, evolution will auto-complete email addresses while typing, which is great!

However, the name it completes on is the name of the mailbox, not the name of the contact.

Depending on your setup, the name of the mailbox may be simply your initials, which isn't very helpful.


On IRC I discussed this with David Woodhouse, and we found out that the data needed to find the contact's name can be obtained by setting ReturnFullContactData="true" when searching for contacts in Exchange.

Please let me know If I can provide further data or help.

Comment 1 David Woodhouse 2011-04-28 15:30:36 UTC

Specifically, I think that in Kåre's case, the name returned in the <Mailbox><Name> is bogus.

The "correct" information is only received in the <Contact><DisplayName> after requesting the full contact data.

Comment 2 Milan Crha 2011-11-21 14:02:17 UTC

Created attachment 201814 [details] [review]
proposed ews patch

for evolution-ews;

I suppose this might do the trick. It did for me.

Comment 3 Milan Crha 2011-11-22 08:13:28 UTC

Downstream bug report from 3.2.2 about a crash to which the above patch  is covered as well:
https://bugzilla.redhat.com/show_bug.cgi?id=754385

+ Trace 229090

Thread 1 (Thread 0x7fd9917fa700 (LWP 15041))

#0 ebews_populate_full_name
at e-book-backend-ews.c line 196
#1 ebews_store_contact_items
at e-book-backend-ews.c line 1673
#2 ebews_sync_items
at e-book-backend-ews.c line 1790
#3 ebews_start_sync
at e-book-backend-ews.c line 1886
#4 delta_thread
at e-book-backend-ews.c line 1940
#5 g_thread_create_proxy
at gthread.c line 1962
#6 start_thread
at pthread_create.c line 309
#7 clone
at ../sysdeps/unix/sysv/linux/x86_64/clone.S line 115

Comment 4 Milan Crha 2011-11-23 10:04:23 UTC

Created attachment 201979 [details] [review]
proposed ews patch ][

for evolution-ews;

Updated patch, to use only SMTP email addresses from the contact information, and if none found, then fallback to an address from the Mailbox node.

Comment 5 Chenthill P 2011-11-23 10:17:59 UTC

Review of attachment 201979 [details] [review]:

Looks good. please commit.

Comment 6 Marko Myllynen 2011-11-23 11:47:36 UTC

The updated patch works perfectly in my testing environment, thanks!

Comment 7 Milan Crha 2011-11-23 11:48:54 UTC

Created commit 89fa2fe in ews master (3.3.3+)

Comment 8 Milan Crha 2011-12-08 08:34:46 UTC

I took the part for the crash and committed it to stable branch too, because we got quite few crash reports downstream from there.

Created commit f719409 in ews gnome-3-2 (3.2.3+)