After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648842 - Notifications are delayed if contacts send messages too fast
Notifications are delayed if contacts send messages too fast
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Notifications
2.33.x
Other Linux
: Normal major
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-28 07:03 UTC by Omer Akram
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
set a not empty string when setting EMPATHY_NOTIFY_MANAGER_CAP_X_CANONICAL_APPEND (1.82 KB, patch)
2011-04-29 15:54 UTC, Guillaume Desmottes
none Details | Review

Description Omer Akram 2011-04-28 07:03:09 UTC
"""
If your contacts send too many messages to you on empathy, you'll see notifications a lot later than expected.
For example:
mrx: hi
mrx: how are you?
mrx: i got your message
mrx: but hey
mrx: I already sent you that...

The you open the conversation and read the whole message and even respond, you'll still have a notification saying "but hey" even when you read that message long ago.

So, if you open a conversation or focus the conversation window, all enqueued messages should be removed from the queue of notifications, or merged into a single one.
"""

This is a regression from empathy 2.32, I can confirm that.
Comment 1 Guillaume Desmottes 2011-04-28 09:04:46 UTC
I guess you are using notify-osd, are you sure that's not a regression there? Aren't we supposed to merge all the messages in the same notification with it?
Comment 2 Omer Akram 2011-04-29 10:20:39 UTC
The problem does not happen with pidgin, i.e. notifications are merged as they should but for empathy each notification comes as a separate message for a few seconds, one after the other.
Comment 3 Guillaume Desmottes 2011-04-29 15:54:16 UTC
Ok I got it. That's because libnotify now filters out the empty string:
http://git.gnome.org/browse/libnotify/commit/?id=54b628500675f6b99f0cb48653c6583d4256d152
Comment 4 Guillaume Desmottes 2011-04-29 15:54:35 UTC
Created attachment 186892 [details] [review]
set a not empty string when setting EMPATHY_NOTIFY_MANAGER_CAP_X_CANONICAL_APPEND

libnotify now filters out empty string so the hint was not set (#648842).
Comment 5 Danielle Madeley 2011-05-02 07:31:43 UTC
++
Comment 6 Guillaume Desmottes 2011-05-02 09:04:21 UTC
Merged to master, 3.0 and 2.34.

commit 7078e93bbcd562175248a8fdf752f2fa92f1171c
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Fri Apr 29 17:53:17 2011 +0200

    set a not empty string when setting EMPATHY_NOTIFY_MANAGER_CAP_X_CANONICAL_APPEND
    
    libnotify now filters out empty string so the hint was not set (#648842).


3.0: 8562c5e1f120d2ef33406d527ecb5599be01be20
2.34: 554ea28a6a158f3dee384c485f84184cf606d61c

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.