Same for 'Read Link Later'. Those are all strings that are translated in the code with _(). The problem is that yelp does not set up translations at all anymore, so you only get translations for those strings where GETTEXT_DOMAIN is somehow passed to gtk, e.g. in .ui files or via gtk_action_group_set_domain.

Yelp still needs to call setlocale, bindtextdomain, etc somewhere early on.

Created attachment 186812 [details] [review]
patch

Thanks for the patch, Matthias.

I'm getting this error when building from jhbuild:

make[2]: Entering directory `/home/gabor/checkout/gnome/yelp/src'
  CC     yelp-yelp-application.o
  CC     yelp-yelp-window.o
  CC     yelp-yelp.o
yelp.c: In function ‘main’:
yelp.c:41: warning: implicit declaration of function ‘setlocale’
yelp.c:41: warning: nested extern declaration of ‘setlocale’
yelp.c:41: error: ‘LC_ALL’ undeclared (first use in this function)
yelp.c:41: error: (Each undeclared identifier is reported only once
yelp.c:41: error: for each function it appears in.)
make[2]: *** [yelp-yelp.o] Error 1

Created attachment 186859 [details] [review]
Fix the build

Thanks, Gabor. I pushed that to master.