After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648736 - Fix seg fault when adding default vcard for new created DB
Fix seg fault when adding default vcard for new created DB
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
unspecified
Other Linux
: Normal major
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-04-27 07:44 UTC by edwin.zhai
Modified: 2011-05-27 12:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix seg fault when adding default vcard for new created DB (868 bytes, patch)
2011-04-27 07:44 UTC, edwin.zhai 		none Details | Review
Clearer logic flow (1.42 KB, patch)
2011-04-28 21:33 UTC, Matthew Barnes 		committed Details | Review

Description edwin.zhai 2011-04-27 07:44:35 UTC 
Created attachment 186715 [details] [review]
Fix seg fault when adding default vcard for new created DB

This is one simple patch to fix seg fault of evolution-data-server, when new contact is added for new created DB.

The root cause is simple: do_create (bf, XIMIAN_VCARD,....) would access
bf->priv->file_db and cause seg fault if not initialized.
Comment 1 Matthew Barnes 2011-04-28 21:33:06 UTC 
Created attachment 186840 [details] [review]
Clearer logic flow

That works, but I see the same assignment a few lines down.  Potential source of confusion in the future.  I tried to make the logic flow a little clearer.  Can you test this?

Also, wow does that default vCard need updated.  I thought we had scrubbed all references to Ximian.
Comment 2 edwin.zhai 2011-05-04 08:02:09 UTC 
(In reply to comment #1)
> Created an attachment (id=186840) [details] [review]
> Clearer logic flow
> 
> That works, but I see the same assignment a few lines down.  Potential source
> of confusion in the future.  I tried to make the logic flow a little clearer. 
> Can you test this?

I have tested your patch with little modification for the old version in poky. It works well. Hope to see it go into upstream.

Thanks,
edwin

> 
> Also, wow does that default vCard need updated.  I thought we had scrubbed all
> references to Ximian.
Comment 3 Ross Burton 2011-05-04 10:30:31 UTC 
Review of attachment 186840 [details] [review]:

In my role as drive-by maintainer, I approve this patch.
Comment 4 Milan Crha 2011-05-27 12:02:21 UTC 
Created commit 9fc9cab in eds master (3.1.2+)