GNOME Bugzilla – Bug 648459
tag: exif: register common tags from tag library
Last modified: 2011-04-24 11:42:25 UTC
Exif uses tags like image-vertical-ppi or image-horizontal-ppi which are registered in gst_tag_register_musicbrainz_tags(), but neither GstExifReader nor GstExifWriter register them. This patch uses a macro definition to rename gst_tag_register_musicbrainz_tags() to gst_tag_library_init() and adds it in the Exif reader's and writer's _init()
Created attachment 186474 [details] [review] tag: exif: register common tags from tag library Exif uses tags like image-vertical-ppi or image-horizontal-ppi which are registered in gst_tag_register_musicbrainz_tags(), but neither GstExifReader nor GstExifWriter register them. This patch uses a macro definition to rename gst_tag_register_musicbrainz_tags() to gst_tag_library_init() and adds it in the Exif reader's and writer's _init()
Thanks, sounds like something that should be done indeed. Not sure I want to add additional defines/API now though, so just moved it into a private header and updated the 0.11 FIXMEs. commit 35c1cf16d9a0750cd98d9202126ced7654272ac0 Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com> Date: Fri Apr 22 13:55:20 2011 +0200 tag: exif: register common tags from tag library Exif uses tags like image-vertical-ppi or image-horizontal-ppi which are registered in gst_tag_register_musicbrainz_tags(), but neither GstExifReader nor GstExifWriter register them. https://bugzilla.gnome.org/show_bug.cgi?id=648459 commit f78a50ed4f7ad21fc23de206356f6d0ce1146914 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Sun Apr 24 12:16:47 2011 +0100 tag: update some FIXMEs for 0.11
Comment on attachment 186474 [details] [review] tag: exif: register common tags from tag library Comitted with changes, thanks!