After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648440 - Toolbar editor should be disabled after toolbar is made invisible.
Toolbar editor should be disabled after toolbar is made invisible.
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-22 04:26 UTC by Tiffany Antopolski
Modified: 2011-04-26 20:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tiffany Antopolski 2011-04-22 04:26:13 UTC
There is a bug against Evince (648056) that now also applies to the fixed development version toolbar (bug #648055):
-------------
steps:

1. View -> Toolbar (make toolbar visible if not visible.  Otherwise go to step
2).
2. Edit -> Toolbar
3. View -> Toolbar (make toolbar invisible).

The Toolbar editor is still visible.  Making the toolbar invisible should
disable the toolbar editor (make it invisible).
Comment 1 Felix Riemann 2011-04-26 16:15:58 UTC
How about making it impossible to hide the toolbar as long as the editor is open?

This would be less intrusive regarding the required code, would make sense as well and together with the fix from bug 648055 would also fix the bug that you can open multiple editor windows (although this is fixable the other way around too).
Comment 2 Tiffany Antopolski 2011-04-26 17:38:58 UTC
So you are thinking of making the view->toolbar and edit->toolbar items insensitive when the toolbar editor is active?
Comment 3 Felix Riemann 2011-04-26 18:15:17 UTC
(In reply to comment #2)
> So you are thinking of making the view->toolbar and edit->toolbar items
> insensitive when the toolbar editor is active?

Yes.

Hiding the toolbar doesn't really make sense in that situation as does opening a second,third,fourth,... editor window.
Comment 4 Tiffany Antopolski 2011-04-26 18:25:32 UTC
makes sense :-)
Comment 5 Felix Riemann 2011-04-26 20:45:35 UTC
There we go. :)

commit 0a16d74a768987241879913f873a68709f3587b2
Author: Felix Riemann <>
Date:   Tue Apr 26 22:39:38 2011 +0200

    Don't allow hiding the toolbar while editing it with the editor
    
    https://bugzilla.gnome.org/show_bug.cgi?id=648440

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.