After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648348 - Poor handling of user accounts without comments
Poor handling of user accounts without comments
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-21 02:23 UTC by Andy Lutomirski
Modified: 2011-04-28 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of an uninformative account (36.50 KB, image/png)
2011-04-26 13:35 UTC, Andy Lutomirski 		  Details
user-accounts: Show username when no real name (2.66 KB, patch)
2011-04-28 13:15 UTC, Bastien Nocera 		reviewed Details | Review
user-accounts: Show username when no real name (1.12 KB, patch)
2011-04-28 13:37 UTC, Bastien Nocera 		committed Details | Review

Description Andy Lutomirski 2011-04-21 02:23:02 UTC 
I have a user account with no comment (obviously created without using gnome-control-center -- it's actually a leftover from before I installed gnome 3).  It shows up in User Accounts with a blank name (on the left panel) and a name of '-' (on the right panel).  Nowhere in the UI do I see the unix name shown.  This makes it rather hard to figure out what I'm looking at.

Screenshot attached.
Comment 1 Matthias Clasen 2011-04-26 13:24:52 UTC 
Screenshot not attached, unfortunately.
Comment 2 Matthias Clasen 2011-04-26 13:27:02 UTC 
But I agree, if the user name is blank, we should show the login instead.
Comment 3 Andy Lutomirski 2011-04-26 13:35:58 UTC 
Created attachment 186650 [details]
Screenshot of an uninformative account

Whoops -- I thought I attached the screenshot.
Comment 4 Bastien Nocera 2011-04-28 13:15:17 UTC 
Created attachment 186815 [details] [review]
user-accounts: Show username when no real name

So that users added "by hand" with adduser show up correctly
in the treeview.
Comment 5 Matthias Clasen 2011-04-28 13:29:12 UTC 
Review of attachment 186815 [details] [review]:

Not sure if it is better to the substitution in the user object or just in the ui.
One thing to avoid is writing it back by accident.
Comment 6 Bastien Nocera 2011-04-28 13:37:00 UTC 
Created attachment 186816 [details] [review]
user-accounts: Show username when no real name

So that users added "by hand" with adduser show up correctly
in the treeview.
Comment 7 Bastien Nocera 2011-04-28 13:38:14 UTC 
Attachment 186816 [details] pushed as b435556 - user-accounts: Show username when no real name