After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648297 - [bus] regression: critical assertion failure
[bus] regression: critical assertion failure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal blocker
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-20 13:41 UTC by Mark Nauwelaerts
Modified: 2011-04-21 11:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
bus: also allow untimed popping of a message if no poll available (1.67 KB, patch)
2011-04-20 13:41 UTC, Mark Nauwelaerts
committed Details | Review

Description Mark Nauwelaerts 2011-04-20 13:41:21 UTC
Created attachment 186355 [details] [review]
bus: also allow untimed popping of a message if no poll available 

Specifically:

GStreamer-CRITICAL **: gst_bus_timed_pop_filtered: assertion `bus->priv->poll != NULL'

Happens when having a pipeline in a pipeline and then changing state back to NULL.  The interior pipeline will/might then flush the bus, which is a child bus from the parent which does not have a poll anymore these days.
Comment 1 Wim Taymans 2011-04-20 15:15:27 UTC
Looks good to me.
Comment 2 Tim-Philipp Müller 2011-04-21 11:34:15 UTC
commit e029aeef9ee27ca310e8f94ce6b765d0be5eafff
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Thu Apr 21 12:33:10 2011 +0100

    tests: add simple pipeline-in-pipeline unit test
    
    https://bugzilla.gnome.org/show_bug.cgi?id=648297

commit 03391a897001d35d1d290f27dd12e98a8b729fb4
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Apr 20 15:39:16 2011 +0200

    bus: also allow popping a message without timeout if no poll available
    
    ... which happens in particular flushing a bus, possibly as part
    of a state change, e.g. when having a pipeline in a pipeline
    and then changing state back to NULL. The interior pipeline
    will/might then flush the bus, which is a child bus from the
    parent which does not have a poll anymore these days.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=648297