After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648233 - gstelement.c:Changing the Debug log message macro in GST_ELEMENT_ERROR to GST_ERROR_OBJECT.
gstelement.c:Changing the Debug log message macro in GST_ELEMENT_ERROR to GST...
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-19 16:29 UTC by sreerenj
Modified: 2011-04-21 23:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gstelement.c:Changing the Debug log message macro in GST_ELEMENT_ERROR to GST_ERROR_OBJECT. (1.38 KB, patch)
2011-04-19 16:29 UTC, sreerenj
rejected Details | Review

Description sreerenj 2011-04-19 16:29:50 UTC
Created attachment 186300 [details] [review]
gstelement.c:Changing the Debug log message macro in GST_ELEMENT_ERROR to GST_ERROR_OBJECT.

It seems that in GST_ELEMENT_ERROR , the debug log macro is used as GST_WARNING_OBJECT. If it something intensional then just close this bug as invalid ! Attached patch Changing it to GST_ERROR_OBJECT.
Comment 1 Tim-Philipp Müller 2011-04-21 12:33:27 UTC
Thanks for the patch, but it is in fact intentional (see commit feb446c5): a GST_ELEMENT_ERROR may be a perfectly normal thing an no cause for alarm, e.g. when a file doesn't exist, or an element couldn't be created, or the sound device couldn't be opened.
Comment 2 sreerenj 2011-04-21 23:25:15 UTC
The commit message is explaining like this "make GST_ELEMENT_ERROR not do GST_ERROR_OBJECT - these errors should be handled by the application and not always printed as well" .!! I don't know why it says like this "NOT ALWAYS PRINTED AS  WELL". In my opinion ,even though the application handling the error,  the debug message should be shown as "error" . Sorry, Otherwise it is creating some confusions during debugging !