After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648214 - Add GDK_LEAVE_NOTIFY_MASK to GeditOverlay even window
Add GDK_LEAVE_NOTIFY_MASK to GeditOverlay even window
Status: RESOLVED OBSOLETE
Product: gedit
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-19 13:51 UTC by Alexandre Mazari
Modified: 2011-09-08 09:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add GDK_LEAVE_NOTIFY_MASK to GeditOverlay even window (949 bytes, patch)
2011-04-19 13:51 UTC, Alexandre Mazari 		accepted-commit_now Details | Review

Description Alexandre Mazari 2011-04-19 13:51:04 UTC 
In the course of implementing a GeditOverlayChild subclass for epiphany [0],
GDK_LEAVE_NOTIFY_MASK was added to the events handled by the window of our
local copy of GeditOverlay.
We use it to restore the child position when the mouse leaves the "relative" widget.
Indeed we play with child coordinates to hide it when the mouse goes close.

To avoid deviation from Gedit version, the proposed patch adds this event mask.


[0] https://bugzilla.gnome.org/show_bug.cgi?id=643909
Comment 1 Alexandre Mazari 2011-04-19 13:51:11 UTC 
Created attachment 186286 [details] [review]
Add GDK_LEAVE_NOTIFY_MASK to GeditOverlay even window
Comment 2 Ignacio Casal Quinteiro (nacho) 2011-04-19 13:53:32 UTC 
Review of attachment 186286 [details] [review]:

Looks good.
Comment 3 Paolo Borelli 2011-09-08 08:21:36 UTC 
the overlay is part of gtk now, is this patch still needed? should it be moved to gtk or should this be closed?
Comment 4 Ignacio Casal Quinteiro (nacho) 2011-09-08 09:18:56 UTC 
Yep let's close it.