GNOME Bugzilla – Bug 648136
design refresh for gtkassistant
Last modified: 2011-05-06 19:00:35 UTC
The gtkassistant hasn't gotten a lot of love over the years. Besides giving it a hug it might be nice to support showing progress through the sequence. Showing progress is reassuring and helps set expectations. Here's a mockup: https://docs.google.com/drawings/pub?id=1JcYvb76IXpod7atLW3IVYNrY8b1fZktjOJR-uxp1S48&w=1257&h=1859
Created attachment 186218 [details] [review] gtk-demo: Don't leave a dangling pointer to a destroyed widget When destroying the assistant, clean up the static variable that points to it.
Created attachment 186219 [details] [review] Add gtk_container_child_notify This is a variant of gtk_widget_child_notify() that takes an explicit container, instead of relying on widget->parent to be the correct container to use.
Created attachment 186220 [details] [review] GtkAssistant: an new style for assistants GtkAssistant is widely recognized as a butt-ugly widget. This commit changes its style to look more modern. We deprecate the sidebar and header image properties and don't show them anymore. Instead, page titles are arranged in a sidebar, with the title of the current page shown in highlighted style.
Created attachment 186221 [details] [review] testassistant: some more tests
Created attachment 186222 [details] [review] Use a different style class for the assistant sidepane So we don't have to tie it directly to how we style nautilus etc sidebars.
Still has a few issues with builder constructed dialogs (eg. gnome-bluetooth's bluetooth-wizard).
What kind of issues are you seeing ? And how does being gtkbuilder-constructed relate ?
Created attachment 186673 [details] [review] another patch The problems in bluetooth-wizard are because it uses gtkbuilder, which in turn uses generic container api to set child properties. So, if we decide to allow child properties on non-direct children, we have to make the generic api work for this too.
Created attachment 186911 [details] [review] final patch The last patch hides consecutive identical page titles, which can make non-linear flows like 1 2a or 2b 3 4 a little more natural. I am happy with the way things look now.
The last chunk of the final patch doesn't seem to apply.
Probably because I did those patches against the gtk-3-0 branch for some reason.