GNOME Bugzilla – Bug 648115
Evince doesn't exits presentation mode at the end of presentation
Last modified: 2018-05-22 14:12:21 UTC
When I open a document in presentation mode, at the end of the presentation, I get a black screen showing "End of presentation, Click to Exit". Pressing down arrow button should exit this presentation (as it happens in OpenOffice/MS Office), but it doesn't exit. I have to click to end the presentation.
Created attachment 192025 [details] [review] patch fixing the bug. compiled and tested against the Git repository I would like to develop additional features, how can I submit my commits to you through Git? What is the preferred format for the evince team? Best Regards!
Review of attachment 192025 [details] [review]: Please squash the two patches using 'git rebase -i master'.
Created attachment 192055 [details] [review] rebase Done! Thanks!
I think I was not clear enough: Please squash the second patch onto the first using 'git rebase -i master' and than choosing to squash, thus merging patch 1 and patch 2 into one proper patch.
(please ignore the hyperlinks in my previous comment, those were added by bugzilla and are not pointing to anything relevant.)
Created attachment 192184 [details] [review] new patch Thanks for the help! Im still new at this. Somehow rebase didnt work. Made a new patch without need of corrections.
I am wondering whether we really want to make this change. Pro: - Compatible with OpenOffice/MSOffice. - Exiting presentation mode is more obvious for any user. Contra: - I actually like the fact that I can keep the PageDown button pressed until Evince reaches the end of a presentation to go through the presentation on high speed, without exiting presentation mode. Exiting presentation mode is something a user should do consciously and deliberately. An alternative could be that we change the text from "End of presentation. Click to exit." to "End of presentation. Press Esc or click to exit." Anyone else have an opinion on this?
While I think you make a good point about the action of exiting the presentation be deliberate, I tend to feel that the compatibility of OOO/MSOffice might bear more weight in this situation. Either way, I suspect it's not going to be that big a deal and probably worth trying the patch as-is since it's already posted.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/213.