After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648086 - Add support for commit numbers
Add support for commit numbers
Status: RESOLVED FIXED
Product: giggle
Classification: Other
Component: libgiggle-git
HEAD
Other Linux
: Normal normal
: ---
Assigned To: giggle-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-18 10:13 UTC by J.P. Lacerda
Modified: 2011-05-01 02:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
giggle-authors (14.00 KB, patch)
2011-04-18 10:14 UTC, J.P. Lacerda 		none Details | Review
Fix whitespace (14.42 KB, patch)
2011-04-18 10:43 UTC, J.P. Lacerda 		none Details | Review
Regex whitespace (16.78 KB, patch)
2011-04-18 11:12 UTC, J.P. Lacerda 		none Details | Review
Remove additional hashtable (15.63 KB, patch)
2011-04-18 12:08 UTC, J.P. Lacerda 		needs-work Details | Review
commit number (6.40 KB, patch)
2011-04-22 22:16 UTC, J.P. Lacerda 		none Details | Review
fix git blame (1.24 KB, patch)
2011-04-22 22:17 UTC, J.P. Lacerda 		none Details | Review
print commits (4.53 KB, patch)
2011-04-22 22:17 UTC, J.P. Lacerda 		none Details | Review

Description J.P. Lacerda 2011-04-18 10:13:28 UTC 
This patch adds support for recording the number of commits a particular GiggleAuthor has. This enables us to organize Properties->Authors by descending number of commits.

In the future, the layout of Properties->Authors could be aesthetically improved upon (i.e. having two columns, one for name and e-mail, and another one for commits).

J.P.
Comment 1 J.P. Lacerda 2011-04-18 10:14:08 UTC 
Created attachment 186189 [details] [review]
giggle-authors
Comment 2 J.P. Lacerda 2011-04-18 10:43:57 UTC 
Created attachment 186191 [details] [review]
Fix whitespace
Comment 3 J.P. Lacerda 2011-04-18 11:12:14 UTC 
Created attachment 186193 [details] [review]
Regex whitespace
Comment 4 J.P. Lacerda 2011-04-18 12:08:34 UTC 
Created attachment 186195 [details] [review]
Remove additional hashtable
Comment 5 Javier Jardón (IRC: jjardon) 2011-04-20 22:37:00 UTC 
Review of attachment 186195 [details] [review]:

Thanks, the patch looks good, some comments:

Seems that you are making 2 changes here: introducing the new function and adding the commits counter feature itself
¿Could you divide this in 2 different patches?

Also, the changes in giggle-file-list.c are not related with this bug
Comment 6 J.P. Lacerda 2011-04-21 10:18:04 UTC 
Thanks for reviewing the patch!

It will be fixed tonight :)

J.P.
Comment 7 J.P. Lacerda 2011-04-22 22:15:48 UTC 
The following patches re-format my work according to your suggestions :)

Thanks, 

J.P.
Comment 8 J.P. Lacerda 2011-04-22 22:16:42 UTC 
Created attachment 186501 [details] [review]
commit number
Comment 9 J.P. Lacerda 2011-04-22 22:17:04 UTC 
Created attachment 186502 [details] [review]
fix git blame
Comment 10 J.P. Lacerda 2011-04-22 22:17:28 UTC 
Created attachment 186503 [details] [review]
print commits
Comment 11 Javier Jardón (IRC: jjardon) 2011-05-01 02:07:02 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.