After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648021 - gst-plugins-bad/gst/nsf/ code not needed (can be replaced by ext/gme/)
gst-plugins-bad/gst/nsf/ code not needed (can be replaced by ext/gme/)
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.19
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-17 13:31 UTC by mihai.draghicioiu
Modified: 2013-05-13 23:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description mihai.draghicioiu 2011-04-17 13:31:45 UTC
The code in the gst/nsf/, decoding nsf game audio files, does the same thing as the code in ext/gme/, which supports several other formats as well. This would require some testing, but the code in ext/gme/ also supports silence detection and infinite loop prevention. So my suggestion is to remove this code. To test that the code in ext/gme works fine, simply build with ./configure --disable-nsf (be sure to remove the old nsf plugin .so file) and try playing back some nsf files. You can find tons here: http://www.zophar.net/music/nsf.html
Comment 1 mihai.draghicioiu 2011-04-17 13:39:48 UTC
Also see https://bugzilla.gnome.org/show_bug.cgi?id=647364#c16 for some more insight
Comment 2 Sebastian Dröge (slomo) 2011-04-18 07:44:03 UTC
The gme plugin needs an external dependency while this doesn't. Maybe just change the rank of the nsf element to SECONDARY and the gme one to PRIMARY?

OTOH I'd be fine with removing the nsf plugin too, nobody really maintains it and gme is better. If nobody complains I'll remove the nsf plugin after the 0.10.22.
Comment 3 Tim-Philipp Müller 2013-05-13 23:16:28 UTC
> OTOH I'd be fine with removing the nsf plugin too, nobody really maintains it
> and gme is better. If nobody complains I'll remove the nsf plugin after the
> 0.10.22.

Nobody complained, I think now is a good time :)

commit f0039c6dc36c905b49272c5b182a2239ccd900b9
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Tue May 14 00:14:34 2013 +0100

    nsf: remove nsf plugin, replaced by gme plugin
    
    https://bugzilla.gnome.org/show_bug.cgi?id=648021