After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647987 - drop the unique name on unregister
drop the unique name on unregister
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gapplication
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-04-17 02:22 UTC by Allison Karlitskaya (desrt)
Modified: 2011-11-19 21:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GApplication: unregister bus name (1.32 KB, patch)
2011-11-18 04:31 UTC, Matthias Clasen
none Details | Review
GApplication: unregister bus name (1.32 KB, patch)
2011-11-19 21:24 UTC, Matthias Clasen
committed Details | Review

Description Allison Karlitskaya (desrt) 2011-04-17 02:22:29 UTC
When a GApplication unregisters (ie: due to the last reference dropping) we should probably release the bus name.  We don't do that now, assuming pretty much that either:

 - GApplication holds the last ref on GDBus session bus so we'll
   disconnect ourselves by unregistering.

 - the app will exit very soon anyway.
Comment 1 Matthias Clasen 2011-04-27 02:18:54 UTC
I agree, dropping the name is obviously right.
Comment 2 Matthias Clasen 2011-11-18 04:31:11 UTC
Created attachment 201644 [details] [review]
GApplication: unregister bus name
Comment 3 Matthias Clasen 2011-11-19 21:24:48 UTC
The following fix has been pushed:
d920cb6 GApplication: unregister bus name
Comment 4 Matthias Clasen 2011-11-19 21:24:51 UTC
Created attachment 201717 [details] [review]
GApplication: unregister bus name