After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647962 - Desensitize "Select All" when GtkEntry is empty
Desensitize "Select All" when GtkEntry is empty
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkEntry
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-04-16 19:25 UTC by Matthew Barnes
Modified: 2011-04-26 11:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Trivial patch (618 bytes, patch)
2011-04-16 19:40 UTC, Matthew Barnes 		needs-work Details | Review
Revised patch (1.21 KB, patch)
2011-04-22 19:53 UTC, Matthew Barnes 		accepted-commit_now Details | Review

Description Matthew Barnes 2011-04-16 19:25:35 UTC 
I got a bug [1] from an Evolution user who was right-clicking in an empty GtkEntry widget and expecting the "Select All" popup menu item to select all items in a tree view.  Had there been text in the entry, the purpose of the menu item would have been made clear on the first try.  But I guess it *is* a little confusing when nothing happens.

(I would prefer non-applicable context menu items be hidden instead of just desensitized, but that's a separate debate.)

[1] bug #647954
Comment 1 Matthew Barnes 2011-04-16 19:40:47 UTC 
Created attachment 186097 [details] [review]
Trivial patch
Comment 2 Matthias Clasen 2011-04-18 00:44:07 UTC 
Review of attachment 186097 [details] [review]:

Can you please give the same treatment to the context menu in GtkTextView ?
Otherwise, looks fine.
Comment 3 Matthew Barnes 2011-04-22 19:53:05 UTC 
Created attachment 186495 [details] [review]
Revised patch

Covers both GtkEntry and GtkTextView.
Comment 4 Matthias Clasen 2011-04-25 11:44:55 UTC 
Review of attachment 186495 [details] [review]:

Please commit