After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647904 - preferences: use GtkBox instead of Gtk[V,H]Box
preferences: use GtkBox instead of Gtk[V,H]Box
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-15 19:56 UTC by Cosimo Cecchi
Modified: 2011-04-18 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
preferences: use GtkBox instead of Gtk[V,H]Box (14.11 KB, patch)
2011-04-15 19:56 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-04-15 19:56:33 UTC 
With GTK3, the default expand packing property changed, and the preferences UI needs to be updated not to expand the boxes in the whole notebook height, which doesn't look really good.
Comment 1 Cosimo Cecchi 2011-04-15 19:56:34 UTC 
Created attachment 186048 [details] [review]
preferences: use GtkBox instead of Gtk[V,H]Box

Use the orientation property of GtkBox to inherit the new proper packing
defaults, otherwise boxes in the preferences will look all spread in the
notebook height.
Comment 2 Guillaume Desmottes 2011-04-18 09:43:27 UTC 
Review of attachment 186048 [details] [review]:

Thanks; please merge to master.
Comment 3 Cosimo Cecchi 2011-04-18 13:17:34 UTC 
Pushed to master, thanks for the review.

Attachment 186048 [details] pushed as f3b2369 - preferences: use GtkBox instead of Gtk[V,H]Box