After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647796 - g_variant_new_variant is not marked as constructor
g_variant_new_variant is not marked as constructor
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal critical
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks: 639952
 
 
Reported: 2011-04-14 16:46 UTC by Sebastian Pölsterl
Modified: 2015-02-07 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
glib-2.0.c: Added annotation for g_variant_new_variant to mark it as constructor (751 bytes, patch)
2011-04-14 17:14 UTC, Sebastian Pölsterl 		committed Details | Review

Description Sebastian Pölsterl 2011-04-14 16:46:28 UTC 
The function g_variant_new_variant is currently marked as method not as constructor.
Comment 1 Sebastian Pölsterl 2011-04-14 17:14:17 UTC 
Created attachment 185971 [details] [review]
glib-2.0.c: Added annotation for g_variant_new_variant to mark it as constructor
Comment 2 Johan (not receiving bugmail) Dahlin 2011-04-15 12:10:57 UTC 
Review of attachment 185971 [details] [review]:

Looks good, please commit.
Comment 3 Sebastian Pölsterl 2011-04-15 13:53:44 UTC 
Thanks, just committed it to master.
Comment 4 Martin Pitt 2011-04-19 07:59:25 UTC 
Apparently this has been committed to gobject-introspection git, but not to the master in glib? Doesn't glib-2.0.c in g-i get autogenerated from the glib source?
Comment 5 Dominique Leuenberger 2011-06-17 13:18:28 UTC 
(In reply to comment #4)
> Apparently this has been committed to gobject-introspection git, but not to the
> master in glib? Doesn't glib-2.0.c in g-i get autogenerated from the glib
> source?

this seems indeed to be a problem, see this commit on gobject-introspection:
http://git.gnome.org/browse/gobject-introspection/commit/?id=6d30588c1c95929694cd3e92c229ebcc46e5449a

The change has thus been reverted.
Comment 6 Colin Walters 2011-06-17 13:41:20 UTC 
I recently switched glib-2.0.c to be auto-generated from glib/glib, but missed that annotation.  Should be fixed now.
Comment 7 André Klapper 2015-02-07 16:46:50 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]