After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647721 - Remove excessive checking for video.c
Remove excessive checking for video.c
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal minor
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-13 21:48 UTC by sreerenj
Modified: 2011-04-14 19:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to clean-up the excessive checking. (3.59 KB, patch)
2011-04-13 21:48 UTC, sreerenj 		committed Details | Review

Description sreerenj 2011-04-13 21:48:16 UTC 
Created attachment 185911 [details] [review]
Patch to clean-up the excessive checking.

It seems that the following function gst_video_format_is_yuv,gst_video_format_is_rgb and gst_video_format_has_alpha are doing excessive checking in switch . Just a clean-up for it.
Comment 1 Sebastian Dröge (slomo) 2011-04-14 08:03:51 UTC 
commit 500d14c35c656890686574e1c041fb556df17056
Author: Sreerenj Balachandran <sreerenj.balachandran@nokia.com>
Date:   Thu Apr 14 00:26:34 2011 +0300

    video: Remove the extensive checkings from switch
    
    The default case handles them already
Comment 2 David Schleef 2011-04-14 19:50:50 UTC 
I'm reverting this.

Every case is specifically listed so that it's easier to find missing cases by adding -Wswitch-enums to CFLAGS.