After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647718 - 'Power' switch label should be renamed to 'Bluetooth'
'Power' switch label should be renamed to 'Bluetooth'
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: properties
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2011-04-13 21:38 UTC by Allan Day
Modified: 2011-06-27 11:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
properties: Use "Bluetooth" instead of "Power" (1.07 KB, patch)
2011-06-27 11:35 UTC, Bastien Nocera
committed Details | Review
Using bluetooth as per mockups (25.01 KB, image/png)
2011-06-27 11:36 UTC, Bastien Nocera
  Details
current master (24.02 KB, image/png)
2011-06-27 11:36 UTC, Bastien Nocera
  Details

Description Allan Day 2011-04-13 21:38:51 UTC
The label should refer to the service which is affected by the switch. Using 'Bluetooth' might mean some repetition, but that's not so bad.

'Bluetooth' will also ensure that the switch is labelled in the same way as in GNOME Shell's System Status Bluetooth menu. This kind of consistency is good.
Comment 1 Bastien Nocera 2011-04-14 01:39:21 UTC
It's obvious what it does in the shell menu, but not in the panel. The reason why one was chosen over the other can be found in the closed bugs for the gnome-bluetooth properties.

Executive decision here. Everything in that dialogue is "Bluetooth". The menu in the shell labels the menu as well as the switch. For the panel, we don't have the same luxury, or top-down presentation that would make it clear that the power for the Bluetooth adapter is being switched.

Unless you can think of a better way to do this, I'm afraid I'll close this bug.
Comment 2 Allan Day 2011-04-14 09:28:10 UTC
The point of the switch widget is that it already carries the message that it controls power. It's a switch: that's what switches do. So it's unnecessary to repeat that messag, in the same way as you wouldn't use 'Enable' or 'On' for the label.

But sure, it's your call; and I don't feel that strongly about this. It's a minor suggestion.
Comment 3 Bastien Nocera 2011-06-27 11:35:10 UTC
Created attachment 190743 [details] [review]
properties: Use "Bluetooth" instead of "Power"
Comment 4 Bastien Nocera 2011-06-27 11:35:56 UTC
(In reply to comment #2)
> The point of the switch widget is that it already carries the message that it
> controls power. It's a switch: that's what switches do.

Visibility power? Zoom power? VPN Connections power? No, certainly not as clear as you would make out. Either that, or we started getting our metaphors muddled.

> So it's unnecessary to
> repeat that messag, in the same way as you wouldn't use 'Enable' or 'On' for
> the label.
> 
> But sure, it's your call; and I don't feel that strongly about this. It's a
> minor suggestion.

Fair enough.
Comment 5 Bastien Nocera 2011-06-27 11:36:36 UTC
Created attachment 190744 [details]
Using bluetooth as per mockups
Comment 6 Bastien Nocera 2011-06-27 11:36:54 UTC
Created attachment 190745 [details]
current master
Comment 7 Bastien Nocera 2011-06-27 11:41:43 UTC
Attachment 190743 [details] pushed as 94be5e4 - properties: Use "Bluetooth" instead of "Power"