After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647667 - Patch for HURD support and small bugfix
Patch for HURD support and small bugfix
Status: RESOLVED DUPLICATE of bug 601497
Product: gvfs
Classification: Core
Component: [obsolete] gdu volume monitor
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-13 14:52 UTC by Raphael Hertzog
Modified: 2011-04-13 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add hurd support, and small bugfix (3.02 KB, patch)
2011-04-13 14:52 UTC, Raphael Hertzog 		none Details | Review

Description Raphael Hertzog 2011-04-13 14:52:55 UTC 
Created attachment 185878 [details] [review]
Patch to add hurd support, and small bugfix

Hello,

HURD doesn't have PATH_MAX so the compilation of monitor/hal/ghalvolumemonitor.c and monitor/gdu/ggduvolumemonitor.c fails. Please find attached a patch that fixes that by changing the way realpath is used on systems using glibc (including hurd).

It also fixes a test that was inverted in the code.

Note that you can drop the #ifdef (and what's in the #else/#endif) if you assume/require POSIX.1-2008 compatibility.

This patch was initially submitted to Debian: http://bugs.debian.org/555055
The attached patch applies fine on top of 1.8.0.

BTW, there are more patches that you might want to review and possibly merge:
http://patch-tracker.debian.org/package/gvfs

They are not well documented but you might find explanations in the changelog:
http://packages.debian.org/changelogs/pool/main/g/gvfs/current/changelog

Thank you!
Comment 1 Raphael Hertzog 2011-04-13 14:55:09 UTC 
Sorry, missed that it was already filed.

*** This bug has been marked as a duplicate of bug 601497 ***