GNOME Bugzilla – Bug 647629
gitg fails to build (missing headers?)
Last modified: 2011-07-21 14:16:56 UTC
Hi, gitg 0.2.2 fails to build on OpenBSD. I have glib 2.28.4 and gtk 3.0.8. Full build log is attached. It appears there is header lacking somewhere?
Created attachment 185845 [details] log of failing build
I can't see anything obvious. Seems gio-unix is there, and include paths are set correctly. It doesn't report including missing headers and the the missing type (GOutputStream) should be defined (I see no reason why not), since gio/unixoutputstream.h is included properly.
As you have openbsd, can you give some light on this?
I finally fixed it. The problem was two-fold: - local headers were being included before system headers - stdin and stdout were being shadowed of sorts. Renaming them to g_std{in,out} fixed it. Attached is a patch. Ok to push it? (Also, http://trac.novowork.com/gitg/ seems to be down, is there another homepage online I can set in the upcoming OpenBSD port?)
Created attachment 192377 [details] [review] Fix build on OpenBSD.
Review of attachment 192377 [details] [review]: Looks good.
Maybe use https://live.gnome.org/Gitg ?
Review of attachment 192377 [details] [review]: Committed.
Created attachment 192378 [details] [review] How about committing this then?
Review of attachment 192378 [details] [review]: 0.2.3 is in the gtk3 branch
Review of attachment 192378 [details] [review]: Ah, right. Minus the version number changes; the homepage sync is desired or just drop this patch?
dunno, I'll talk with the maintainer and see if he wants to change it. Thanks for the patches. I'm closing this as fixed then.
Sure, thank you too.