After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647629 - gitg fails to build (missing headers?)
gitg fails to build (missing headers?)
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gitg
git master
Other OpenBSD
: Normal major
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-13 08:07 UTC by Jasper Lievisse Adriaanse
Modified: 2011-07-21 14:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
log of failing build (43.46 KB, text/plain)
2011-04-13 08:08 UTC, Jasper Lievisse Adriaanse 		  Details
Fix build on OpenBSD. (5.45 KB, patch)
2011-07-21 13:50 UTC, Jasper Lievisse Adriaanse 		committed Details | Review
How about committing this then? (1.19 KB, patch)
2011-07-21 14:04 UTC, Jasper Lievisse Adriaanse 		rejected Details | Review

Description Jasper Lievisse Adriaanse 2011-04-13 08:07:47 UTC 
Hi,

gitg 0.2.2 fails to build on OpenBSD. I have glib 2.28.4 and gtk 3.0.8. Full build log is attached. It appears there is header lacking somewhere?
Comment 1 Jasper Lievisse Adriaanse 2011-04-13 08:08:20 UTC 
Created attachment 185845 [details]
log of failing build
Comment 2 jessevdk@gmail.com 2011-04-15 10:52:23 UTC 
I can't see anything obvious. Seems gio-unix is there, and include paths are set correctly. It doesn't report including missing headers and the the missing type (GOutputStream) should be defined (I see no reason why not), since gio/unixoutputstream.h is included properly.
Comment 3 Ignacio Casal Quinteiro (nacho) 2011-07-21 13:15:00 UTC 
As you have openbsd, can you give some light on this?
Comment 4 Jasper Lievisse Adriaanse 2011-07-21 13:49:48 UTC 
I finally fixed it. The problem was two-fold:
- local headers were being included before system headers
- stdin and stdout were being shadowed of sorts. Renaming them to g_std{in,out} fixed it.

Attached is a patch. Ok to push it?

(Also, http://trac.novowork.com/gitg/ seems to be down, is there another homepage online I can set in the upcoming OpenBSD port?)
Comment 5 Jasper Lievisse Adriaanse 2011-07-21 13:50:06 UTC 
Created attachment 192377 [details] [review]
Fix build on OpenBSD.
Comment 6 Ignacio Casal Quinteiro (nacho) 2011-07-21 13:56:02 UTC 
Review of attachment 192377 [details] [review]:

Looks good.
Comment 7 Ignacio Casal Quinteiro (nacho) 2011-07-21 13:56:21 UTC 
Maybe use https://live.gnome.org/Gitg ?
Comment 8 Jasper Lievisse Adriaanse 2011-07-21 14:04:15 UTC 
Review of attachment 192377 [details] [review]:

Committed.
Comment 9 Jasper Lievisse Adriaanse 2011-07-21 14:04:43 UTC 
Created attachment 192378 [details] [review]
How about committing this then?
Comment 10 Ignacio Casal Quinteiro (nacho) 2011-07-21 14:05:27 UTC 
Review of attachment 192378 [details] [review]:

0.2.3 is in the gtk3 branch
Comment 11 Jasper Lievisse Adriaanse 2011-07-21 14:06:59 UTC 
Review of attachment 192378 [details] [review]:

Ah, right. Minus the version number changes; the homepage sync is desired or just drop this patch?
Comment 12 Ignacio Casal Quinteiro (nacho) 2011-07-21 14:11:52 UTC 
dunno, I'll talk with the maintainer and see if he wants to change it. Thanks for the patches. I'm closing this as fixed then.
Comment 13 Jasper Lievisse Adriaanse 2011-07-21 14:16:56 UTC 
Sure, thank you too.