GNOME Bugzilla – Bug 647531
[gajim] notification doesn't go away and all messages are mingled together
Last modified: 2011-09-03 09:28:11 UTC
Created attachment 185775 [details] illustrating screenshot gajim extension starts and works (both I can see incoming messages and I can reply to it). However, when I stop chatting with the particular person, the notification doesn't go away from the notification area. Also, other chats where I am involved are now shown in the same notification area which has the old title and avatar. See the attached exmaple. I have started to chat with my friend Tomáš Landovský in one-to-one conversation. When we stopped I switched to IRC channel (via IRC transport) #jetpack on irc.mozilla.org and chatted with warner about something. Unfortuantely, all this is recorded in the same notification window with old title and old avatar.
It is possible that line 278 of extension.js is failing to retrieve the author, therefore setting it to "undefined". Can you please add a line log('New conversation, data is [' + data + ']') at the beginning of that function, and report what you see in .xsession-errors? Thanks!
I haven't tested the gajim "IRC transport". In fact it's the first time I hear about that. So yeah, there could indeed be a misbehavior in the extension. Thanks for reporting this issue! I'll try to reproduce it here.
Ok I managed to find an IRC transport and join a channel (kind of tricky)... but I get this: JS ERROR: !!! Exception was: Error: No property 'text' in property list (or its value was undefined) JS ERROR: !!! lineNumber = '0' JS ERROR: !!! fileName = 'gjs_throw' JS ERROR: !!! stack = 'Error("No property 'text' in property list (or its value was undefined)")@:0 ("No property 'text' in property list (or its value was undefined)")@gjs_throw:0 _private_St_Label([object Object])@:0 ([object Object])@/home/phil/gnome-shell/install/share/gnome-shell/js/ui/messageTray.js:966 SummaryItem([object Object])@/home/phil/gnome-shell/install/share/gnome-shell/js/ui/messageTray.js:945 ([object Object])@/home/phil/gnome-shell/install/share/gnome-shell/js/ui/messageTray.js:1295 ([object Object],null)@/home/phil/.local/share/gnome-shell/extensions/gajim@gnome-shell-extensions.gnome.org/extension.js:130 ([object Object],null)@/home/phil/gnome-shell/install/share/gjs-1.0/lang.js:110 ' JS ERROR: !!! message = 'No property 'text' in property list (or its value was undefined)' So the notification is not added in the messageTray at all. Will try to investigate this issue a bit more.
Sorry for the delay, I've finally tracked that one down. One question Matěj, the notification was displaying messages coming from you to the IRC room, right? Was it also displaying messages from other people of the room? The issue I found is that if you don't close the notification and start chatting in a jabber room the messages you send appear in the notification. The solution for this is do filter messages (like it's done in _messageReceived) in _messageSent. I'll update my patch of bug 657475 to address this issue. Could this bug be closed as dupe of bug 657475 please?
(In reply to comment #4) > Could this bug be closed as dupe of bug 657475 please? Sure. *** This bug has been marked as a duplicate of bug 657475 ***