Created attachment 185773 [details] [review]
add SMS button to new-message dialog

http://git.collabora.co.uk/?p=user/danni/empathy.git;a=shortlog;h=refs/heads/sms-support-2

Based on the work for bug #644086.

Review of attachment 185773 [details] [review]:

This SMS button should be sensitive only if the contact supports SMS (SMS is advertised in his capabilities).

Created attachment 185844 [details] [review]
updated patch

Updated to check the SMS capability in the RCC.

Review of attachment 185844 [details] [review]:

::: libempathy-gtk/empathy-contact-selector-dialog.c
@@ +514,3 @@
+        "Current account selected in the account-chooser",
+        TP_TYPE_ACCOUNT,
+        G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

Does it really make sense to have this prop writable?

(In reply to comment #4)

> Does it really make sense to have this prop writable?

I don't see why not.

++

All three SMS branches ready to merge here:
https://gitorious.org/glassrose-gnome/empathy/commits/danni-sms-support-2

Awesome, thanks a lot of the forward port.

Danni: can you please look at this branch please? I think it's fine with you're the one who wrote the original code so best to double check.

This looks pretty good, I'm just building Empathy to test it.

Based on the problems with my first two patches (see #644085), I've pulled them out and replaced them with one patch on top (0fda59487) here:

http://cgit.collabora.co.uk/git/user/danni/empathy.git/log/?h=sms-support-rebase

++ go go go :)

Merged.

I think all the SMS branches have been merged to master now; closing.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.