After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647361 - file-psd-save does not embed color profile
file-psd-save does not embed color profile
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
unspecified
Other All
: Normal major
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2011-04-10 13:37 UTC by Yoshinori Yamakawa
Modified: 2011-05-07 08:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for git master (2.78 KB, patch)
2011-04-10 13:37 UTC, Yoshinori Yamakawa 		none Details | Review
Patch for gimp-2-6 branch (2.78 KB, patch)
2011-04-10 13:39 UTC, Yoshinori Yamakawa 		none Details | Review

Description Yoshinori Yamakawa 2011-04-10 13:37:10 UTC 
Created attachment 185638 [details] [review]
Patch for git master

The file-psd-load plug-in can read embedded color profile, but the file-psd-save plug-in does not embed color profile. It should be fixed.
Comment 1 Yoshinori Yamakawa 2011-04-10 13:39:53 UTC 
Created attachment 185639 [details] [review]
Patch for gimp-2-6 branch
Comment 2 Mukund Sivaraman 2011-05-06 14:43:15 UTC 
(In reply to comment #0)
> Created an attachment (id=185638) [details] [review]
> Patch for git master
> 
> The file-psd-load plug-in can read embedded color profile, but the
> file-psd-save plug-in does not embed color profile. It should be fixed.

I have verified that the profile gets saved correctly using Imagemagick.

This patch is only going into master. It won't be committed into GIMP 2.6.x.

I have committed a slightly modified version of your patch to avoid using deprecated API and also fix warnings.

commit 759fad8189c9790dcef5efe727092f99d3461792
Author:     Yoshinori Yamakawa <yamma-ma@users.sourceforge.jp>
AuthorDate: Sun Apr 10 18:39:22 2011 +0900
Commit:     Mukund Sivaraman <muks@banu.com>
CommitDate: Fri May 6 20:08:57 2011 +0530

    file-psd: Make file-psd-save embed color profile
Comment 3 Yoshinori Yamakawa 2011-05-07 03:13:42 UTC 
Many users will use GIMP 2.6 for months.
Would you please commit a patch into gimp-2.6 branch for them?
Comment 4 Mukund Sivaraman 2011-05-07 03:51:31 UTC 
(In reply to comment #3)
> Many users will use GIMP 2.6 for months.
> Would you please commit a patch into gimp-2.6 branch for them?

2.6 is a maintenance only branch. No new features can go into 2.6. All new features go into master, and will be released as part of 2.8 when it's ready.
Comment 5 Yoshinori Yamakawa 2011-05-07 06:06:33 UTC 
New feature?
It's just a fix of the bug where it doesn't do what it's supposed to.
Comment 6 Mukund Sivaraman 2011-05-07 06:25:54 UTC 
(In reply to comment #5)
> New feature?
> It's just a fix of the bug where it doesn't do what it's supposed to.

It isn't going into 2.6. In any case, there's no current plan to make another 2.6.x release. Please accept it, and await it as part of the 2.8 release.
Comment 7 Takashi Sakamoto 2011-05-07 08:07:50 UTC 
I wonder why GIMP can read its color profile but cannot save it as the same format. I think this is not the new function, it's simply the bug for 2.6 branch. This one-way function will make the users puzzled.

Could you deal with this issue as a bug and put Yoshinori's patch in 2.6 branch?
Comment 8 Mukund Sivaraman 2011-05-07 08:25:26 UTC 
No.

I'm going to stop replying to this bug, as I don't think any more replies are going to help make you understand. There are no current plans to make any more 2.6.x releases.