After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647336 - Use GdmGreeterServer from python-dbus client causes xml error in introspection
Use GdmGreeterServer from python-dbus client causes xml error in introspection
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-10 02:36 UTC by Martin Owens
Modified: 2011-05-25 01:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.02 KB, patch)
2011-04-10 02:36 UTC, Martin Owens 		committed Details | Review

Description Martin Owens 2011-04-10 02:36:28 UTC 
Created attachment 185624 [details] [review]
Patch

The introspection xml was missing a method end-tag, I've attached a patch from your git head which should fix the issue.

Although I question the wisdom of having the xml inside the c code in the first place. Make sanity checking impossible.
Comment 1 Ray Strode [halfline] 2011-05-25 00:48:10 UTC 
completely agree. we should change this to use gdbus's new codegen features at some point.
Comment 2 Ray Strode [halfline] 2011-05-25 00:50:33 UTC 
Thanks for the patch, and sorry for the slowish turn around on it.
Comment 3 Martin Owens 2011-05-25 01:28:32 UTC 
Thanks for patching, let me know if you guys would like the python greeter packaged as an example greeter for other programmers.