After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647303 - Looking Glass don't close with Esc key if it's selected a tab other than Evaluator
Looking Glass don't close with Esc key if it's selected a tab other than Eval...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.0.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-09 18:30 UTC by Rudinei Goi Roecker
Modified: 2011-05-16 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
lookingGlass: make Esc work on any page (2.59 KB, patch)
2011-04-20 16:48 UTC, Dan Winship 		committed Details | Review

Description Rudinei Goi Roecker 2011-04-09 18:30:27 UTC 
As it is explained on the summary, the looking glass feature (at least on fedora live image) don't close if you are using a tab other than Evaluator. To close the lg you have to (re)select the Evaluator tab, then press the Esc key. In my opinion it should close on all tabs, not just on the Evaluator tab. In addition, as it's commented on the bug 642664, the lg should close or minimize if it looses focus (and if it's implemented a minimize function, then can be added a key to bring it up again).
Comment 1 Finnbarr P. Murphy 2011-04-19 15:41:24 UTC 
It would be nice if the Esc key also worked for the Picker pane.
Comment 2 Dan Winship 2011-04-20 16:48:17 UTC 
Created attachment 186376 [details] [review]
lookingGlass: make Esc work on any page

The lg window was losing focus when the page with the entry got unmapped;
fix it to refocus itself after that.

Fixing this problem revealed that previously we were focusing the
entry on open(), but not ensuring that that page was selected, meaning
you could type into the entry without being able to see it. Fix that.
Comment 3 Yichao Yu 2011-05-06 15:02:34 UTC 
It sometimes work well when you exit lg last time because you click on a url and thus enter "extensions" tab next time entering. (But it still annoying)
Comment 4 Colin Walters 2011-05-11 20:56:03 UTC 
Review of attachment 186376 [details] [review]:

Looks OK.
Comment 5 Dan Winship 2011-05-16 10:44:23 UTC 
Attachment 186376 [details] pushed as bee37b5 - lookingGlass: make Esc work on any page