After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647293 - Fix pad callbacks so they handle when parent goes away
Fix pad callbacks so they handle when parent goes away
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.x
Other All
: Normal critical
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-09 17:13 UTC by Haakon Sporsheim (ieei)
Modified: 2011-04-13 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (9.48 KB, patch)
2011-04-09 17:13 UTC, Haakon Sporsheim (ieei) 		none Details | Review
improved patch (13.25 KB, patch)
2011-04-11 21:44 UTC, Haakon Sporsheim (ieei) 		committed Details | Review

Description Haakon Sporsheim (ieei) 2011-04-09 17:13:34 UTC 
Created attachment 185596 [details] [review]
patch

1) We need to lock and get a strong ref to the parent, if still there.
2) If it has gone away, we need to handle that gracefully.

This is necessary in order to safely modify a running pipeline. Has been
observed when a streaming thread is doing a buffer_alloc() while an
application thread sends an event on a pad further downstream, and from
within a pad probe (holding STREAM_LOCK) carries out the pipeline plumbing
while the streaming thread has its buffer_alloc() in progress.
Comment 1 Tim-Philipp Müller 2011-04-09 19:07:37 UTC 
Not really a blocker, since it's not a regression and a long-standing issue.
Comment 2 Haakon Sporsheim (ieei) 2011-04-09 19:18:20 UTC 
Would be nice to get it in, since a couple of similar fixes got in a couple of days ago.
Comment 3 Håvard Graff (hgr) 2011-04-09 19:45:42 UTC 
(In reply to comment #1)
> Not really a blocker, since it's not a regression and a long-standing issue.

My bad, I asked Haakon to post as blocker, following the "get yer attention before release"-schema. So you take it out on me Tim! :)
Comment 4 Haakon Sporsheim (ieei) 2011-04-11 21:44:37 UTC 
Created attachment 185760 [details] [review]
improved patch
Comment 5 Sebastian Dröge (slomo) 2011-04-13 15:43:40 UTC 
Pushed this patch as three patches (for ghostpad, base and elements). Thanks :)