After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647230 - Display the blank split after the "now" line instead of at the end
Display the blank split after the "now" line instead of at the end
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Register
unspecified
Other All
: Normal enhancement
: future
Assigned To: gnucash-ui-maint
gnucash-ui-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-08 22:37 UTC by Simon Arlott
Modified: 2018-06-29 22:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch implementing this feature for 2.4.12 (3.28 KB, patch)
2013-05-05 00:01 UTC, Simon Arlott
none Details | Review
Patch implementing this feature for 2.6 (git 2014-05-08) (17.51 KB, patch)
2014-05-25 17:19 UTC, Simon Arlott
needs-work Details | Review
Patch implementing this feature for 2.8 (git 2014-09-16) (16.84 KB, patch)
2014-09-17 19:24 UTC, Simon Arlott
committed Details | Review

Description Simon Arlott 2011-04-08 22:37:19 UTC
I have a lot of transactions entered for the future, so the default scroll position at the end is inconvenient as recent transactions aren't visible without scrolling. The automatic placement of the blank split at the end also means that I can't see the recent transactions while entering a new one (although moving the blank split means that the future transactions would then not be visible instead).

There should be a configuration option to place the blank split immediately after the "now" line (possibly with an extra line below it to make this clearer) and default the scroll position when opening the register so that the blank split is in the middle of the visible area.
Comment 1 Simon Arlott 2013-05-05 00:01:43 UTC
Created attachment 243319 [details] [review]
Patch implementing this feature for 2.4.12

This sets the skip taskbar hint to FALSE (the default is TRUE for GtkMessageDialog). The dialog windows then appear (albeit with no name) in the taskbar.
Comment 2 Simon Arlott 2013-05-05 00:06:55 UTC
Ignore the previous comment/attachment, it relates to a different bug. Bugzilla is missing a "delete comment" feature.
Comment 3 Simon Arlott 2014-05-25 17:19:13 UTC
Created attachment 277152 [details] [review]
Patch implementing this feature for 2.6 (git 2014-05-08)

I've added a preference to enable this behaviour, but the default scroll position when opening the register always has the blank transaction at the top of the window instead of the middle (if there are enough future dated transactions).
Comment 4 Geert Janssens 2014-09-16 19:55:02 UTC
Comment on attachment 277152 [details] [review]
Patch implementing this feature for 2.6 (git 2014-05-08)

Thank you for your patch.

Can you drop the change made to src/app-utils/migratable-prefs.xml.in please ?
Allow me to explain: that file lists preferences that should be migrated from the old gconf backend used in gnucash 2.4 and earlier to the new gsettings backend used in gnucash 2.6 and more recent. As you are introducing a new preference in master (and hence 2.8), your preference will never appear in gconf and hence shouldn't be marked for migration.

Other than that your patch looks fine.
Comment 5 Geert Janssens 2014-09-16 19:55:56 UTC
(In reply to comment #3)
> Created an attachment (id=277152) [details] [review]
> Patch implementing this feature for 2.6 (git 2014-05-08)
> 
> I've added a preference to enable this behaviour, but the default scroll
> position when opening the register always has the blank transaction at the top
> of the window instead of the middle (if there are enough future dated
> transactions).

What made you change your mind about the position of the blank transaction (top vs middle) ?
Comment 6 Simon Arlott 2014-09-16 22:13:04 UTC
(In reply to comment #5)
> (In reply to comment #3)
> > Created an attachment (id=277152) [details] [review] [details] [review]
> > Patch implementing this feature for 2.6 (git 2014-05-08)
> > 
> > I've added a preference to enable this behaviour, but the default scroll
> > position when opening the register always has the blank transaction at the top
> > of the window instead of the middle (if there are enough future dated
> > transactions).
> 
> What made you change your mind about the position of the blank transaction (top
> vs middle) ?

Nothing, I'm not familiar enough with how the GUI works to fix it.

Just moving the blank transaction itself was good enough to start with. If you can get it to scroll to the middle that would be better.

(I think it also needs to scroll up by one line when you add a new transaction dated in the past, so that the blank transaction position stays constant.)
Comment 7 Simon Arlott 2014-09-17 19:24:18 UTC
Created attachment 286418 [details] [review]
Patch implementing this feature for 2.8 (git 2014-09-16)

Changes to src/app-utils/migratable-prefs.xml.in removed.
Comment 8 Geert Janssens 2014-09-27 11:09:19 UTC
Comment on attachment 286418 [details] [review]
Patch implementing this feature for 2.8 (git 2014-09-16)

Thanks for the updated patch.

I don't know either how to keep the blank line in the middle of the register window when there are many  future transactions.

The change as it is works already good enough to include it in master. Which is what I just did.

Thank you for your contribution !
Comment 9 John Ralls 2018-06-29 22:56:23 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=647230. Please update any external references or bookmarks.