After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647127 - Formatstring issue in modules/console.c
Formatstring issue in modules/console.c
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-08 01:54 UTC by Tobias Mueller
Modified: 2011-04-09 15:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch which fixes the format string issue (741 bytes, patch)
2011-04-08 01:55 UTC, Tobias Mueller 		committed Details | Review

Description Tobias Mueller 2011-04-08 01:54:49 UTC 
GJS suffers a format string problem in modules/console.c. fprintf is not used correctly, i.e. no literal format string is given.
Comment 1 Tobias Mueller 2011-04-08 01:55:35 UTC 
Created attachment 185492 [details] [review]
Patch which fixes the format string issue
Comment 2 Colin Walters 2011-04-08 14:37:56 UTC 
Review of attachment 185492 [details] [review]:

The patch looks fine.  Can you use this style for the commit message (just run "git log" to see lots of examples):

console: Add a missing format string

https://bugzilla.gnome.org/show_bug.cgi?id=647127
Comment 3 Tobias Mueller 2011-04-09 15:35:59 UTC 
Comment on attachment 185492 [details] [review]
Patch which fixes the format string issue

Just pushed a reworded version.