After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647123 - shell: fix commandline handling
shell: fix commandline handling
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-08 01:21 UTC by Matthias Clasen
Modified: 2011-04-08 19:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (2.68 KB, patch)
2011-04-08 01:21 UTC, Matthias Clasen
accepted-commit_after_freeze Details | Review
patch including translations (861.74 KB, patch)
2011-04-08 14:39 UTC, Matthias Clasen
none Details | Review

Description Matthias Clasen 2011-04-08 01:21:19 UTC
Created attachment 185490 [details] [review]
patch

The original problem was reported here: https://bugzilla.redhat.com/show_bug.cgi?id=691172

Using --help quits an already running control-center instance.

Here is a patch that fixes the commandline handling.
Comment 1 Bastien Nocera 2011-04-08 01:33:48 UTC
Comment on attachment 185490 [details] [review]
patch

Looks good to me.
Comment 2 Bastien Nocera 2011-04-08 12:30:06 UTC
Comment on attachment 185490 [details] [review]
patch

Actually, will need committing after 3.2.
Comment 3 Matthias Clasen 2011-04-08 14:16:32 UTC
No, it just needs a freeze break request.
Or better still, stealing of existing translations from glib
Comment 4 Matthias Clasen 2011-04-08 14:39:00 UTC
Created attachment 185528 [details] [review]
patch including translations