After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647090 - i18n support in glchess is broken
i18n support in glchess is broken
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-chess-maint
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-07 19:44 UTC by Gabor Kelemen
Modified: 2013-05-24 01:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Another bunch of untranslatable strings (6.19 KB, patch)
2011-04-08 20:36 UTC, Gabor Kelemen
committed Details | Review

Description Gabor Kelemen 2011-04-07 19:44:06 UTC
The i18n support is broken in the rewritten glchess, particularly, the gettext initialization (setlocale, bindtextdomain calls) is missing. Also, several strings are not marked for translation.
Comment 1 Robert Ancell 2011-04-08 00:53:06 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 2 Gabor Kelemen 2011-04-08 20:36:37 UTC
Created attachment 185550 [details] [review]
Another bunch of untranslatable strings

I'm afraid there are more strings that are not translatable. Here is one bunch, but this isn't all of it.

I was unable to figure out how to mark properly for translation the multiline about_dialog.license text[1], but that's also something we usually translate. Perhaps it would be simpler to use the template text from libgames-support/games-stock.c. Or use a stock GtkLicense: http://developer.gnome.org/gtk3/stable/GtkAboutDialog.html#GtkLicense

Also, we have some output for --help, and I'm not entirely sure that it is the best to expose all of that for translators. When using GOption only the descriptions and parameters are translatable, thus the not-to-be-translated texts are foolproof, and that's good.

[1]: _("""This is not supported by intltool""") and _("This is not supported by Vala") for multi line texts, at least as long as my little experiments show.
Comment 3 Robert Ancell 2011-04-11 04:25:41 UTC
Review of attachment 185550 [details] [review]:

Thanks Gabor, pushed to master and gnome-3-0
Comment 4 Michael Catanzaro 2013-05-06 01:50:59 UTC
Well it's been two years, and from my check of the Spanish version of gnome-chess, the only problem I notice is the title of the game in the About dialog.  Gabor, are you aware of any other remaining issues?
Comment 5 Michael Catanzaro 2013-05-24 01:35:34 UTC
Closing this as I'm not aware of any remaining i18n issues. Please make new bugs as needed, thanks!