After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647077 - still looks in gconf for proxy settings
still looks in gconf for proxy settings
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
fixed-3-0
Depends on:
Blocks:
 
 
Reported: 2011-04-07 18:16 UTC by Matthias Clasen
Modified: 2011-09-15 07:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use gsettings for proxy settings (12.76 KB, patch)
2011-04-07 20:57 UTC, Christian Persch 		reviewed Details | Review

Description Matthias Clasen 2011-04-07 18:16:59 UTC 
GNOME 3.0 stores its proxy configuration in dconf nowadays. 
gnome-terminal still looks in gconf...
Comment 1 Christian Persch 2011-04-07 18:20:14 UTC 
I have this fixed in my gsettings branch already.
Comment 2 Matthias Clasen 2011-04-07 18:27:16 UTC 
Oh lovely. Any chance to land that soon ?
Comment 3 Christian Persch 2011-04-07 20:57:52 UTC 
Created attachment 185475 [details] [review]
Use gsettings for proxy settings

It sucks to construct four GSettings object to just get a few settings
and then immediately dispose them again, but the fix for that depends on
fixed that exist only in my glib gsettingslist branch.

Bug #647077.
Comment 4 Islam Amer 2011-04-17 08:54:04 UTC 
I tested this patch and it works, hope it lands in a release soon :)

Thanks!
Comment 5 Dan Winship 2011-04-19 17:27:25 UTC 
Comment on attachment 185475 [details] [review]
Use gsettings for proxy settings

>+  if (is_http && !g_settings_get_boolean (child_settings, "enabled"))
>+    goto out;

actually, the network control panel never sets that key, so you should ignore it (and we should update gsettings-desktop-schemas to indicate that it is unused).

Everything else looks right, but I haven't tested it. It would be nice to get this in for 3.0.1.
Comment 6 Peter Weber 2011-09-15 07:09:17 UTC 
Not fixed yet in 3.0.1 on Fedora 15


Also the env should be set! Like every user of a POSIX/UNIX would expect.

Nearly every application can use the env (bash, curl, different browsers and tools....yum!). And nearly no application uses gsettings currently, including gnome-terminal :-(