After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646984 - Use libbluray to get thumbnails
Use libbluray to get thumbnails
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: [obsolete] gdu volume monitor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-07 03:00 UTC by Bastien Nocera
Modified: 2011-04-07 22:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
common: Use libbluray to get Blu-Ray metadata (14.31 KB, patch)
2011-04-07 20:58 UTC, Bastien Nocera
none Details | Review
common: Use libbluray to get Blu-Ray metadata (14.69 KB, patch)
2011-04-07 21:46 UTC, Bastien Nocera
none Details | Review
common: Use libbluray to get Blu-Ray metadata (16.53 KB, patch)
2011-04-07 22:43 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2011-04-07 03:00:38 UTC
Instead of my current attempt at reading XML files directly, we should be using libbluray to read the metadata off the disc.

Example usage:
http://git.videolan.org/?p=libbluray.git;a=blob;f=src/examples/bd_info.c;h=0ede3701dd06850ec21c02997b1900aa7d6ac087;hb=HEAD

Note that libbluray doesn't do any of the decryption, etc.
Comment 1 Bastien Nocera 2011-04-07 20:58:13 UTC
Created attachment 185476 [details] [review]
common: Use libbluray to get Blu-Ray metadata

This means we can finally get localised versions, and
support the biggest thumbnails.
Comment 2 Bastien Nocera 2011-04-07 21:46:35 UTC
Created attachment 185481 [details] [review]
common: Use libbluray to get Blu-Ray metadata

This means we can finally get localised versions, and
support the biggest thumbnails.
Comment 3 David Zeuthen (not reading bugmail) 2011-04-07 21:50:51 UTC
Sounds like a good idea to me.

Btw, we should probably make it such that other backends use these functions as well... for example, I'm really missing not having this functionality (and x-content-type to e.g. launch Totem) in the archive:// backend for e.g. .iso file mounts. Want me to open a bug for that?
Comment 4 Bastien Nocera 2011-04-07 22:43:58 UTC
Created attachment 185482 [details] [review]
common: Use libbluray to get Blu-Ray metadata

This means we can finally get localised versions, and
support the biggest thumbnails.
Comment 5 Bastien Nocera 2011-04-07 22:45:05 UTC
(In reply to comment #3)
> Sounds like a good idea to me.
> 
> Btw, we should probably make it such that other backends use these functions as
> well... for example, I'm really missing not having this functionality (and
> x-content-type to e.g. launch Totem) in the archive:// backend for e.g. .iso
> file mounts. Want me to open a bug for that?

Yes please.
Comment 6 Bastien Nocera 2011-04-07 22:45:48 UTC
Found another slight bug from which the BDMV name would never get applied (forgot an else...). Cherry-picked it to gnome-3-0.
Comment 7 Bastien Nocera 2011-04-07 22:46:39 UTC
Attachment 185482 [details] pushed as 21c319c - common: Use libbluray to get Blu-Ray metadata