After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646963 - rtpmanager: Only update last_rtcp_send_time when actually sending a report
rtpmanager: Only update last_rtcp_send_time when actually sending a report
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal major
: 1.1.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2011-04-06 22:00 UTC by Håvard Graff (hgr)
Modified: 2013-09-18 16:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch (1.69 KB, patch)
2011-04-06 22:00 UTC, Håvard Graff (hgr)
none Details | Review

Description Håvard Graff (hgr) 2011-04-06 22:00:56 UTC
Created attachment 185366 [details] [review]

Comment 1 Olivier Crête 2011-04-11 21:22:59 UTC
Actually, when you send an RTCP APP report, don't you send a full Compound RTCP packet ? In which case, I think you want to reset the RTCP timer. Or do you send a Minimal Compound RTCP packet ?

If I read your patch correctly.. its the same as removing the if() completely, since data.rtcp will only be set is is_rtcp_time() returns TRUE.

That said, we may want to move the timer resetting after the "on-sending-rtcp" signal to make sure the timer is only reset if the RTCP packet has not been supressed..
Comment 2 Wim Taymans 2012-12-13 10:51:15 UTC
Comment 3 Tim-Philipp Müller 2013-04-19 16:15:45 UTC
Pascal: ping?
Comment 4 Pascal Buhler 2013-04-22 06:30:54 UTC
This patch maybe missing some context, but going on memory the idea was that last_rtcp_send_time should only be updated when a full packet (ie one that contain full SR/RR's) is being sent. This was definitely someting added after we did some support for minimal RTCP packets so with out that change it is maybe irreverent.

I would also agree that updating last_rtcp_send_time should happen only if the packet was actually sent.
Comment 5 Wim Taymans 2013-09-12 12:22:52 UTC
I think this is correct now and the patch is irrelevant.