GNOME Bugzilla – Bug 646963
rtpmanager: Only update last_rtcp_send_time when actually sending a report
Last modified: 2013-09-18 16:47:15 UTC
Created attachment 185366 [details] [review]
Actually, when you send an RTCP APP report, don't you send a full Compound RTCP packet ? In which case, I think you want to reset the RTCP timer. Or do you send a Minimal Compound RTCP packet ?
If I read your patch correctly.. its the same as removing the if() completely, since data.rtcp will only be set is is_rtcp_time() returns TRUE.
That said, we may want to move the timer resetting after the "on-sending-rtcp" signal to make sure the timer is only reset if the RTCP packet has not been supressed..
This patch maybe missing some context, but going on memory the idea was that last_rtcp_send_time should only be updated when a full packet (ie one that contain full SR/RR's) is being sent. This was definitely someting added after we did some support for minimal RTCP packets so with out that change it is maybe irreverent.
I would also agree that updating last_rtcp_send_time should happen only if the packet was actually sent.
I think this is correct now and the patch is irrelevant.