After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646960 - GSimpleAsyncResult should not be created in callback
GSimpleAsyncResult should not be created in callback
Status: RESOLVED DUPLICATE of bug 646957
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other Linux
: Normal normal
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on: 646957
Blocks:
 
 
Reported: 2011-04-06 21:28 UTC by Nicolas Dufresne (ndufresne)
Modified: 2011-04-26 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't allocated GSimpleAsync from async callback (4.33 KB, patch)
2011-04-06 21:28 UTC, Nicolas Dufresne (ndufresne) 		none Details | Review

Description Nicolas Dufresne (ndufresne) 2011-04-06 21:28:31 UTC 
Created attachment 185364 [details] [review]
Don't allocated GSimpleAsync from async callback

As GSimpleAsyncResult saves default thread context, it's slightly risky to create it in the callback of another async function. An object could by example be implemented in a  way that it always reply in the context where it was created from, regardless the context of the call, and chaining an async call.

As this is still very vague, I'm attaching a patch fixing this type of calling GDbusProxy. Note that until bug #646957, this cannot really cause any harm as chaining GIO calls always end up being replied on the main default context.
Comment 1 Dan Winship 2011-04-26 15:31:45 UTC 
I think we're going with 646957, which makes this unnecessary

*** This bug has been marked as a duplicate of bug 646957 ***