After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646954 - rtpgstpay: declare frag_offset to hold 32 bits
rtpgstpay: declare frag_offset to hold 32 bits
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.x
Other All
: Normal normal
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-06 20:19 UTC by Haakon Sporsheim (ieei)
Modified: 2011-04-09 22:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Declare as 32bit instead of 16. (793 bytes, patch)
2011-04-06 20:20 UTC, Haakon Sporsheim (ieei)
committed Details | Review
Declare as const (828 bytes, patch)
2011-04-06 20:21 UTC, Haakon Sporsheim (ieei)
rejected Details | Review

Description Haakon Sporsheim (ieei) 2011-04-06 20:19:38 UTC
Not much to say about these. Two one-liners. See attached patches.
Comment 1 Haakon Sporsheim (ieei) 2011-04-06 20:20:17 UTC
Created attachment 185357 [details] [review]
Declare as 32bit instead of 16.
Comment 2 Haakon Sporsheim (ieei) 2011-04-06 20:21:08 UTC
Created attachment 185358 [details] [review]
Declare as const
Comment 3 Tim-Philipp Müller 2011-04-09 22:16:51 UTC
Pushed the first one, second one doesn't apply (and looks outdated):

 commit fd545e260d2f49a1a3ad39463ff5a21f4c1497f4
Author: Haakon Sporsheim <haakon.sporsheim@gmail.com>
Date:   Tue Apr 5 21:14:43 2011 +0200

    rtpgstpay: declare frag_offset to hold 32bits.
    
    As specified in documenation above and below.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=646954