GNOME Bugzilla – Bug 646925
encoding-profile: Remove unused variables
Last modified: 2011-04-12 09:12:14 UTC
.
Created attachment 185321 [details] [review] encoding-profile: Remove unused variables
Review of attachment 185321 [details] [review]: ::: gst-libs/gst/pbutils/encoding-target.c @@ -456,3 @@ profpreset = gst_encoding_profile_get_preset (prof); - proftype = gst_encoding_profile_get_type_nick (prof); - profrestriction = gst_encoding_profile_get_restriction (prof); I think the nick and restrictions of profiles should be serialized/deserialized too. Edward?
I think they are still taken into account in the whole code.
> I think they are still taken into account in the whole code. Where/how? Could you check please? Do "top-level" profiles never have restrictions (vs. "stream profiles")? The type nick is taken into account (a few lines below), but I don't see the restriction being taken into account.
only stream profiles have restrictions
Pushed, thanks: commit 3fa0119dc13f8861f68f8b7b108ce137e3508d53 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Apr 6 16:27:54 2011 +0100 encoding-profile: fix unused-but-set-variable warnings with gcc 4.6 Top-level profiles don't have restrictions, only stream profiles, so no need to serialise that here. https://bugzilla.gnome.org/show_bug.cgi?id=646925 Also see bug #647294 for gcc-4.6 related issues in -base.
Comment on attachment 185321 [details] [review] encoding-profile: Remove unused variables Committed with minor changes (used proftype variable instead of removing it).