After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646870 - HTML_IMAGES no longer in EXTRA_DIST
HTML_IMAGES no longer in EXTRA_DIST
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.17
Other All
: Normal critical
: 1.18
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-06 02:08 UTC by Yaakov Selkowitz
Modified: 2011-04-07 19:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Restore HTML_IMAGES to EXTRA_DIST (1.36 KB, patch)
2011-04-06 02:08 UTC, Yaakov Selkowitz
none Details | Review

Description Yaakov Selkowitz 2011-04-06 02:08:11 UTC
Created attachment 185245 [details] [review]
Restore HTML_IMAGES to EXTRA_DIST

Commit 7d083da removed HTML_IMAGES from SETUP_FILES in order to handle the case where an image file is created at build time in the builddir.   However, this caused HTML_IMAGES to
be removed from EXTRA_DIST as well, resulting in HTML_IMAGES not being
shipped in tarballs built with gtk-doc 1.17, and if built with --enable-gtk-doc, the build of such packages fails.

Patch attached, but a complete fix will require rebuilding all gtk-doc'ed tarballs with a version of gtk-doc containing this patch.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2011-04-07 19:25:10 UTC
Ohh, right. Thanks for the patch. In case you have an idea, how I could detect such a regression in the tests, let me know. I'll soon make another release then.

commit a938ba9ba1212fc490e351cfd7d6574a2bff29f2
Author: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Date:   Tue Apr 5 20:58:40 2011 -0500

    Restore HTML_IMAGES to EXTRA_DIST
    
    Commit 7d083dacd622d061d12fc60046135897fc2102fc removed HTML_IMAGES from
    SETUP_FILES in order to handle the case where an image file is created
    at build time in the builddir.  However, this caused HTML_IMAGES to be
    removed from EXTRA_DIST as well, resulting in HTML_IMAGES not being
    shipped in tarballs built with gtk-doc 1.17, and if built with
    --enable-gtk-doc, the build of such packages fails.