After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646855 - search-tab: Don't handle clicks on inactive icon
search-tab: Don't handle clicks on inactive icon
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: GnomeShell301
 
 
Reported: 2011-04-05 20:04 UTC by Florian Müllner
Modified: 2011-04-11 19:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
search-tab: Don't handle clicks on inactive icon (1.38 KB, patch)
2011-04-05 20:04 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-04-05 20:04:24 UTC 
Minor bug I stumbled upon while reviewing bug 636341.
Comment 1 Florian Müllner 2011-04-05 20:04:30 UTC 
Created attachment 185231 [details] [review]
search-tab: Don't handle clicks on inactive icon

The icon set as secondary icon of the search entry depends on whether
a search is active or not - clicking the icon should reset the entry
only in the former case. This is implemented by connecting/disconnecting
the 'secondary-icon-clicked' signal when updating the icon, but an
additional signal connection was left-over when refactoring the search
entry, resulting in clicks on the inactive icon removing the hint text.
Fix by removing the stray signal connection.
Comment 2 Dan Winship 2011-04-11 18:18:34 UTC 
Comment on attachment 185231 [details] [review]
search-tab: Don't handle clicks on inactive icon

this does indeed look redundant
Comment 3 Florian Müllner 2011-04-11 19:01:51 UTC 
Attachment 185231 [details] pushed as 018e3bc - search-tab: Don't handle clicks on inactive icon