After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646840 - shmsink: ensure gst_poll_wait is the first gst_poll function called on a descriptor
shmsink: ensure gst_poll_wait is the first gst_poll function called on a desc...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-05 16:33 UTC by Vincent Penquerc'h
Modified: 2011-04-07 08:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shmsink: ensure gst_poll_wait is the first gst_poll function called on a descriptor (1.20 KB, patch)
2011-04-05 16:33 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2011-04-05 16:33:13 UTC 
Created attachment 185217 [details] [review]
shmsink: ensure gst_poll_wait is the first gst_poll function called on a descriptor

shmsink: ensure gst_poll_wait is the first gst_poll function called on a descriptor
Comment 1 Olivier Crête 2011-04-06 14:13:02 UTC 
Comment on attachment 185217 [details] [review]
shmsink: ensure gst_poll_wait is the first gst_poll function called on a descriptor

Looks good to me
Comment 2 Sebastian Dröge (slomo) 2011-04-07 08:04:28 UTC 
commit a34108899ea5027be67e8a2c77c4ef67c093eb83
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Apr 5 19:26:15 2011 +0300

    shmsink: ensure gst_poll_wait is called first on descriptors
    
    We need to call gst_poll_wait before calling gst_poll_* status
    functions on that new descriptor, so restart the loop, so _wait
    will have been called on all elements of self->poll, whether
    they have just been added or not. */