GNOME Bugzilla – Bug 646670
Personal Information (contactinfo) dialog doesn't handle different kinds of phone numbers
Last modified: 2012-03-15 10:46:20 UTC
Created attachment 185070 [details] screenshot of Personal Information The contactinfo for a CM supports 3 vcard fields of type 'tel': 'type=home', 'type=work' and 'type=cell'. Empathy doesn't seem to distinguish between these, and setting one would seem to set them all.
Created attachment 185927 [details] [review] initial patch http://git.collabora.co.uk/?p=user/danni/empathy.git;a=shortlog;h=refs/heads/contactinfo-646670 This is an initial patch which factors out the common code between empathy-individual-widget and empathy-contact-widget. It also adds converting the parameters GStrv into a list of interesting things. I say initial, because it needs to be a little bit smarter because Gabble gives things like parameters=[ tel=home, tel=work ], which is a little confusing, and I think we should filter out weird ones... or maybe we should change Gabble to not do this.
Any chance you could rebase this on top of master? It's based on pretty old code.
Getting there with this rebase. Includes some rewriting. It's bitrotten annoyingly much.
These are the display patches (i.e. the non-WIP stuff). I think we should merge these ASAP and follow up with the editing side once I've made it work. http://cgit.collabora.com/git/user/danni/empathy.git/log/?h=rebase-contactinfo
http://cgit.collabora.com/git/user/danni/empathy.git/commit/?h=rebase-contactinfo&id=76334ee642c834a3476b6c46e8962329a0b4d83a You should add the new file to POTFILES.in http://cgit.collabora.com/git/user/danni/empathy.git/commit/?h=rebase-contactinfo&id=c5a2ea143f1b45c5062997d099a04b7615ea58fa could be squashed How does this affect UI? It looks mostly like factoring out code to me.
> How does this affect UI? It looks mostly like factoring out code to me. It adds new strings for the type=badger stuff. So we can't put it in 3.2.
(In reply to comment #5) > http://cgit.collabora.com/git/user/danni/empathy.git/commit/?h=rebase-contactinfo&id=76334ee642c834a3476b6c46e8962329a0b4d83a > You should add the new file to POTFILES.in Fixed. > http://cgit.collabora.com/git/user/danni/empathy.git/commit/?h=rebase-contactinfo&id=c5a2ea143f1b45c5062997d099a04b7615ea58fa > could be squashed I considered it, but decided it was nicer separate because you could see the rebasing. Will do if requested.
Ping.
Go for it!
Comment on attachment 185927 [details] [review] initial patch Ok, the rebased branch is merged. Need to rebase and finish the editing part of this, which I sketched out, but haven't had the motivation to implement yet.
Bug #672034 is about editing so let's close this bug as the first patch has been merged since a while.