After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646660 - Sound indicator should provide a mute button
Sound indicator should provide a mute button
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
2.91.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-03 22:34 UTC by Luis Medinas
Modified: 2011-04-26 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
PopupSliderMenuItem: intercept clicks outside the slider (1.30 KB, patch)
2011-04-21 15:51 UTC, Giovanni Campagna
committed Details | Review

Description Luis Medinas 2011-04-03 22:34:56 UTC
Sound indicator should provide a mute button it makes sense to quickly mute sound.
Comment 1 Giovanni Campagna 2011-04-04 12:14:28 UTC
This was discussed in bug 634329, and it was decided that a mute button is unnecessary.
Comment 2 Luis Medinas 2011-04-04 13:28:25 UTC
Giovanni, can this feature be added as an extension then ? I'll be interested in develop such feature if gnome-shell designers don't want this feature.
Comment 3 Giovanni Campagna 2011-04-04 14:29:50 UTC
Techically, it is possible but you need to replace the whole sound menu (declare it in the extension and set Panel.STANDARD_TRAY_ICON_SHELL_IMPLEMENTATION['volume']).
This said, I don't think that a mute button is so useful, given that in most cases you have an hardware mute key, and if not you can set a keybinding, in case you need to disable sound immediately. But I like to say "code first, design later", so I have no problems with including this.
Comment 4 Bastien Nocera 2011-04-11 17:07:58 UTC
The easy way to do this would be to extend the volume bar's reach to both the left and right of the bar itself, so that clicking on the empty space bring the volume to the minimum.

It would also make it finger friendly, which is always a good thing.
Comment 5 Giovanni Campagna 2011-04-21 15:51:54 UTC
Created attachment 186435 [details] [review]
PopupSliderMenuItem: intercept clicks outside the slider

Connect to button-press-event on the menu item actor, not on the
slider, so any part that is highlighted is also clicked. This means
that click on the left of the volume slider is a rapid way to mute.
Comment 6 Dan Winship 2011-04-26 14:36:55 UTC
Comment on attachment 186435 [details] [review]
PopupSliderMenuItem: intercept clicks outside the slider

doh. wish I had looked at the patch before 3.0.1. we could have gotten this in.
Comment 7 Giovanni Campagna 2011-04-26 15:03:50 UTC
Attachment 186435 [details] pushed as d104f92 - PopupSliderMenuItem: intercept clicks outside the slider