GNOME Bugzilla – Bug 646630
account-widgets: fix glade sizing issues
Last modified: 2011-09-26 10:59:30 UTC
The account widgets of the different protocols have ugly size issues. To verify this just open empathy-accounts and resize the window to something big (let's say twice the default size) and you'll see that widgets expand and ugly spaces are created. These patches try to fix that.
Created attachment 185037 [details] [review] e-account-widget-jabber: fix sizing issues Fix the glade file for sizing issues Bug #646630
Created attachment 185038 [details] [review] e-account-widget-msn: fix sizing issues Fix glade file for sizing issues. Bug #646630
One of my remaining problems with this is that when you open the accounts preferences in control-center you get a fixed size window. It sucks for the Advanced expander of jabber settings. I'd like to make the expander make the window as big as possible/necessary, but still be in the viewport so it can be resized if necessary. I think what I'm saying is that the "natural" size should be "everything visible" when the expander is open, but should not force "natural" to be "minimum". Don't know if this is clear :)
> One of my remaining problems with this is that when you open the accounts > preferences in control-center you get a fixed size window. > It sucks for the Advanced expander of jabber settings. The control-center integration has gone away (bug #655388) so that's not really an issue any more. :) We've done some changes in the accounts dialog recently. Could you please try rebasing your patches and check if there are still needed?
Been testing master, and yes, sometimes there are really weird sizes in the accounts window. I'll try to rebase this weekend.
Any progress on this?
Created attachment 197243 [details] [review] e-account-widget-jabber: Use GtkGrid instead of GtkTable This work around bug #657621
My patch applies on top of attachment #185037 [details]. With both, the dialog seems perfect now :) Note that attachment #185038 [details] does not apply on master anymore...
ok, merge both jabber patches. Same change is needed on all other widgets now.
Created attachment 197334 [details] [review] Glade: GtkGrid does not have n-rows and n-columns properties as GtkTable
Created attachment 197335 [details] [review] Glade: fix sizing in SIP accounts widget
Created attachment 197336 [details] [review] empathy-account: add a --assistant option to force having assistant This makes easier to test it
Created attachment 197337 [details] [review] e-account-widget-irc: Use a GtkGrid to fix label wrapping
Review of attachment 197334 [details] [review]: ++
Review of attachment 197336 [details] [review]: Will merge to master after branching as that introduces a new string.
Review of attachment 197335 [details] [review]: ++
Review of attachment 197337 [details] [review]: ++
Created attachment 197341 [details] [review] glade: remove unseless placeholder added by Glade editor
Created attachment 197345 [details] [review] empathy-account: add a --assistant option to force having assistant This makes easier to test it
Created attachment 197346 [details] [review] e-account-widget-irc: Use a GtkGrid to fix label wrapping
Ok, everything merged to master now, for 3.4.