GNOME Bugzilla – Bug 646622
Misc libcheese fixes
Last modified: 2011-04-11 21:02:49 UTC
Here's a few fixes I had to make in order to use libcheese to implement webcam support in The Board.
Created attachment 185026 [details] [review] lib: add some missing introspection annotations in cheese-camera
Created attachment 185027 [details] [review] lib: fix typo when initializing photo_path private attribute
Created attachment 185028 [details] [review] lib: no need to declare variable to retun photo/video path
Created attachment 185029 [details] [review] lib: allocate new string to return photo/video paths
Created attachment 185030 [details] [review] lib: add missing glib.h include in cheese-fileutil.h
Created attachment 185031 [details] [review] lib: properly prefix photo/video suffix constants in cheese namespace
Created attachment 185061 [details] [review] lib: use private attributes instead of unnecessary method call
Created attachment 185062 [details] [review] lib: fix leaks and simplify cheese_fileutil_get_new_media_filename
Review of attachment 185026 [details] [review]: Looks good.
Review of attachment 185027 [details] [review]: Indeed. Not sure what the consequence of this would be, but it might need to get in before the release. Also, should change those to g_settings_get_string(), this usage is just silly.
Review of attachment 185028 [details] [review]: Typo in commit message ("retun"). Looks good otherwise.
Review of attachment 185029 [details] [review]: Any reason not to return a "const char *" instead?
Review of attachment 185030 [details] [review]: Good.
Review of attachment 185031 [details] [review]: Yep.
Review of attachment 185061 [details] [review]: No need to do this if we return const char (unless we like micro-optimisations).
Review of attachment 185062 [details] [review]: Looks good.
Review of attachment 185030 [details] [review]: Can't we just change the glib-object inclusion to before the G_BEGIN_DECLS?
Review of attachment 185029 [details] [review]: No strong reason. Just thought returning char * was the original intent of the API. Will change it to return const char * and fix/drop all resulting changes.
(In reply to comment #17) > Review of attachment 185030 [details] [review]: > > Can't we just change the glib-object inclusion to before the G_BEGIN_DECLS? Right. Done.
fyi: i just created a new branch gnome-3-0.
All patches committed with the suggested changes. Closing.