After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646594 - gnome-panel not following gobject introspection best practice
gnome-panel not following gobject introspection best practice
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
3.0.x
Other All
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-03 04:05 UTC by Allison Karlitskaya (desrt)
Modified: 2015-03-24 15:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the patch that should be applied immediately without looking (1.16 KB, patch)
2011-04-03 04:05 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2011-04-03 04:05:11 UTC 
Created attachment 185015 [details] [review]
the patch that should be applied immediately without looking

the code has this:

girdir = $(INTROSPECTION_GIRDIR)
gir_DATA = $(INTROSPECTION_GIRS)

typelibdir = $(INTROSPECTION_TYPELIBDIR)
typelib_DATA = $(INTROSPECTION_GIRS:.gir=.typelib)

but the wiki page for autotool integration says you should do it like this:

  girdir = $(datadir)/gir-1.0
  gir_DATA = $(INTROSPECTION_GIRS)

  typelibdir = $(libdir)/girepository-1.0
  typelib_DATA = $(INTROSPECTION_GIRS:.gir=.typelib)

The reason for that is because the existing Makefile breaks on "make install" if you try to install gnome-panel into a prefix with system gobject introspection (because it results in trying to install files to /usr).
Comment 1 André Klapper 2012-07-15 22:07:44 UTC 
Patch seems to be still valid - ping: vuntz?
Comment 2 Vincent Untz 2012-07-16 06:08:02 UTC 
I guess I don't see the point of $(INTROSPECTION_GIRDIR) and $(INTROSPECTION_TYPELIBDIR), then. Isn't it better to fix those variables to point to something useful? It sounds wrong to me to put gir-1.0 in all Makefile.am and suffer when we'll bump the gir version...