After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646577 - rtppayload: Make RTP time information accessible
rtppayload: Make RTP time information accessible
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-02 21:32 UTC by Håvard Graff (hgr)
Modified: 2014-04-12 05:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (4.14 KB, patch)
2011-04-02 21:32 UTC, Håvard Graff (hgr)
none Details | Review

Description Håvard Graff (hgr) 2011-04-02 21:32:54 UTC
Created attachment 184992 [details] [review]
patch

For FLUX (Clearpath) we need to have RTP time in the encoder and decoder
for feedback messages.
Comment 1 Olivier Crête 2011-04-03 02:22:42 UTC
For the decoder, maybe with the 0.11 buffer, the RTP header info (or maybe the whole rtp header), should be attached to each buffer ?
Comment 2 Sebastian Dröge (slomo) 2011-04-04 07:45:30 UTC
You should add some gtk-doc chunks above the property installation into the class, including Since markers for the gst-plugins-base version where they were added. Also you might want to g_object_notify() whenever the property changes
Comment 3 Pascal Buhler 2011-04-04 23:27:20 UTC
I agree with Olivier, adding such much meta data to buffers would remove the need to this property and would help with other things as well.

I will add some doc and the g_object_notify, what would be the appropriate values for the since marker?
Comment 4 Olivier Crête 2011-04-05 00:16:59 UTC
The next -base release.. (right now 0.10.33)
Comment 5 Wim Taymans 2014-04-12 04:29:37 UTC
commit f0348d700560957bb43f321b812a016b7a2a0fe0
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Sat Apr 12 06:27:36 2014 +0200

    rtpbasepayload: add current timestamp and seqnum offset to stats
    
    Expose the current timestamp and seqnum offset in the stats
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=646577
Comment 6 Wim Taymans 2014-04-12 05:12:25 UTC
Please use stats now

commit f2ee068729ec9f56bd9c7d05004e2bd6baf31189
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Sat Apr 12 07:10:36 2014 +0200

    rtpbasedepay: add stats property
    
    Add a stats property that holds a structure with all the current
    values of the depayloader.
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=646577