After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646575 - rtcpbuffer: Round to next 32bit word, not current 32bit word at end of SDES chunk
rtcpbuffer: Round to next 32bit word, not current 32bit word at end of SDES c...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal blocker
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-02 21:28 UTC by Håvard Graff (hgr)
Modified: 2011-04-05 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (876 bytes, patch)
2011-04-02 21:28 UTC, Håvard Graff (hgr)
none Details | Review
corrected the author (878 bytes, patch)
2011-04-04 12:06 UTC, Håvard Graff (hgr)
committed Details | Review

Description Håvard Graff (hgr) 2011-04-02 21:28:26 UTC
Created attachment 184990 [details] [review]
patch

...
Comment 1 Sebastian Dröge (slomo) 2011-04-04 07:41:48 UTC
I don't know enough about RTCP to review this... but if it talks about rounding, always going to the next 32bit word seems less likely than the ceiling round that is currently done ;) But then, I have no idea about that code :)
Comment 2 Pascal Buhler 2011-04-04 11:30:50 UTC
The code is parsing a list, at the end of the list there is a "0". When the "0" is reached the offset should be changed to be the first byte after the current 32 bit word.
So if the current offset is 4 then that is pointing to the first byte in the second 32 bit word and so after this operation offset should be 8 which is the first byte in the third 32bit word.
(4+3)&~3 = 4  (wrong)
(4+4)&~3 = 8  (write)
Comment 3 Håvard Graff (hgr) 2011-04-04 12:06:04 UTC
Created attachment 185101 [details] [review]
corrected the author
Comment 4 Sebastian Dröge (slomo) 2011-04-05 13:27:47 UTC
Ok, thanks for the explanation. Makes sense :)

commit 1ad98b0d98c8701273b5e6e4e42b9daff4f40bec
Author: Pascal Buhler <pascal.buhler@tandberg.com>
Date:   Tue Aug 24 13:14:33 2010 +0200

    rtcpbuffer: Round to next 32bit word, not current 32bit word at end of SDES