After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646572 - baseaudiosrc: protect against ringbuffer disappearing while in a query
baseaudiosrc: protect against ringbuffer disappearing while in a query
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal critical
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-02 21:24 UTC by Håvard Graff (hgr)
Modified: 2011-04-04 07:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.69 KB, patch)
2011-04-02 21:24 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2011-04-02 21:24:07 UTC 
Created attachment 184987 [details] [review]
patch

Observed a case where the src went to null-state during the query,
hence the spec pointer was no longer valid, and
gst_util_unit64_scale_int crashed (assertion `denom > 0 failed)

Add locking to make sure the ringbuffer can´t disappear.
Comment 1 Sebastian Dröge (slomo) 2011-04-04 07:34:50 UTC 
commit 63cfa2a50da29ef897ce598abe60a3cbda950989
Author: Havard Graff <havard.graff@tandberg.com>
Date:   Sat Jan 22 23:09:32 2011 +0100

    baseaudiosrc: protect against ringbuffer disappearing while in a query
    
    Observed a case where the src went to null-state during the query,
    hence the spec pointer was no longer valid, and
    gst_util_unit64_scale_int crashed (assertion `denom > 0´failed)
    
    Add locking to make sure the ringbuffer can't disappear.