After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646531 - GST_BOILERPLATE: don't use "type" as both a variable name and a macro argument
GST_BOILERPLATE: don't use "type" as both a variable name and a macro argument
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-02 13:53 UTC by Bastien Nocera
Modified: 2011-04-02 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
utils: Avoid using a type name as variable name (2.40 KB, patch)
2011-04-02 13:53 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2011-04-02 13:53:17 UTC 
Caused warnings when used.
Comment 1 Bastien Nocera 2011-04-02 13:53:19 UTC 
Created attachment 184943 [details] [review]
utils: Avoid using a type name as variable name

This caused "re-declaration" problems.
./clutter-gst-video-sink.c: In function ‘clutter_gst_video_sink_init_interfaces’:
./clutter-gst-video-sink.c:231:1: warning: declaration of ‘ClutterGstVideoSink’ shadows a global declaration [-Wshadow]
./clutter-gst-video-sink.h:64:44: warning: shadowed declaration is here [-Wshadow]
Comment 2 Tim-Philipp Müller 2011-04-02 14:21:53 UTC 
Oops :)  Pushed, thanks:

commit 08e189badbeffcce1ee9addbdee7023b676ce6c7
Author: Bastien Nocera <hadess@hadess.net>
Date:   Sat Apr 2 14:51:18 2011 +0100

    utils: Avoid using "type" as name for a variable and a macro argument in GST_BOILERPLATE
    
    This caused "re-declaration" problems.
    ./clutter-gst-video-sink.c: In function ‘clutter_gst_video_sink_init_interfaces’:
    ./clutter-gst-video-sink.c:231:1: warning: declaration of ‘ClutterGstVideoSink’ shadows a global declaration [-Wshadow]
    ./clutter-gst-video-sink.h:64:44: warning: shadowed declaration is here [-Wshadow]
    
    https://bugzilla.gnome.org/show_bug.cgi?id=646531